Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 2736483002: Enable and remove 2 tests in WebRtcVideoChannel2Test (Closed)
Patch Set: Removing an unfinished test that hasn't been touched for at least a year. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 62e1ea760cd05a64b993f3cea32531cc920c3fcc..bf5537f161b18205733dde682783a60d568b2755 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -2973,22 +2973,11 @@ TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsRejectUnsupportedCodec) {
EXPECT_FALSE(channel_->SetRecvParameters(parameters));
}
-// TODO(pbos): Enable VP9 through external codec support
-TEST_F(WebRtcVideoChannel2Test,
- DISABLED_SetRecvCodecsAcceptsMultipleVideoCodecs) {
- cricket::VideoRecvParameters parameters;
- parameters.codecs.push_back(GetEngineCodec("VP8"));
- parameters.codecs.push_back(GetEngineCodec("VP9"));
- EXPECT_TRUE(channel_->SetRecvParameters(parameters));
-}
-
-TEST_F(WebRtcVideoChannel2Test,
- DISABLED_SetRecvCodecsSetsFecForAllVideoCodecs) {
+TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsAcceptsMultipleVideoCodecs) {
cricket::VideoRecvParameters parameters;
parameters.codecs.push_back(GetEngineCodec("VP8"));
parameters.codecs.push_back(GetEngineCodec("VP9"));
EXPECT_TRUE(channel_->SetRecvParameters(parameters));
- FAIL(); // TODO(pbos): Verify that the FEC parameters are set for all codecs.
}
TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsWithoutFecDisablesFec) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698