DescriptionRevert of move some warning suppressions from SocketRocket. (patchset #2 id:70001 of https://codereview.webrtc.org/2718653002/ )
Reason for revert:
Breaks AppRTCMobile in release configuration
Original issue's description:
> Reland of move some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2714123002/ )
>
> Reason for revert:
> Buildbot issues have been fixed.
>
> Original issue's description:
> > Revert of Remove some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2704383004/ )
> >
> > Reason for revert:
> > Breaks buildbot
> >
> > Original issue's description:
> > > Remove some warning suppressions from SocketRocket.
> > >
> > > These warnings started appearing on a clang update. This CL patches the
> > > vendored library and removes the supression. We assert on the return as
> > > we're not equipped to deal with failures there anyway.
> > >
> > > BUG=webrtc:6396
> > > NOTRY=true
> > >
> > > Review-Url: https://codereview.webrtc.org/2704383004
> > > Cr-Commit-Position: refs/heads/master@{#16820}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d
> >
> > TBR=kjellander@webrtc.org,magjed@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:6396
> >
> > Review-Url: https://codereview.webrtc.org/2714123002
> > Cr-Commit-Position: refs/heads/master@{#16822}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/e47de1a69c2f574d71728b16825f8cdbf7407481
>
> TBR=kjellander@webrtc.org,magjed@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6396
>
> Review-Url: https://codereview.webrtc.org/2718653002
> Cr-Commit-Position: refs/heads/master@{#16823}
> Committed: https://chromium.googlesource.com/external/webrtc/+/00df91ce50c71b7895ec24246c71c08568236967
TBR=kjellander@webrtc.org,magjed@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6396
Review-Url: https://codereview.webrtc.org/2718703002
Cr-Commit-Position: refs/heads/master@{#16829}
Committed: https://chromium.googlesource.com/external/webrtc/+/0b34577625ef63d0dea9c72ac9972d111b359ff7
Patch Set 1 #Patch Set 2 : Introduce temp variable for assert #
Messages
Total messages: 7 (3 generated)
|