Remove some warning suppressions from SocketRocket.

Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
NOTRY=true

Review-Url: https://codereview.webrtc.org/2704383004
Cr-Commit-Position: refs/heads/master@{#16820}
Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d

[kthelgason, 2017-02-23 08:06:30]

Description was changed from

==========
Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
==========

to

==========
Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
==========

[kthelgason, 2017-02-23 10:42:37]

kthelgason@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-02-24 08:30:38]

lgtm

I guess you can use NOTRY=True

[kthelgason, 2017-02-24 08:31:01]

Description was changed from

==========
Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
==========

to

==========
Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
NOTRY=true
==========

[kthelgason, 2017-02-24 08:31:06]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2017-02-24 08:31:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 08:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 08:35:44]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13995)

[kthelgason, 2017-02-24 08:37:39]

kthelgason@webrtc.org changed reviewers:
+ magjed@webrtc.org

[kthelgason, 2017-02-24 08:37:40]

+magjed for OWNER review.

[magjed_webrtc, 2017-02-24 09:27:39]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-02-24 09:27:40]

lgtm

[commit-bot: I haz the power, 2017-02-24 09:27:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-24 09:30:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487928459671660, "parent_rev":
"b5388d77489388e5a9941cca9b979f9cfb4c8f76", "commit_rev":
"49990e88fb523901b28d10f2026602cb86528b0d"}

[commit-bot: I haz the power, 2017-02-24 09:30:03]

Description was changed from

==========
Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
NOTRY=true
==========

to

==========
Remove some warning suppressions from SocketRocket.

These warnings started appearing on a clang update. This CL patches the
vendored library and removes the supression. We assert on the return as
we're not equipped to deal with failures there anyway.

BUG=webrtc:6396
NOTRY=true

Review-Url: https://codereview.webrtc.org/2704383004
Cr-Commit-Position: refs/heads/master@{#16820}
Committed:
https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f20...
==========

[commit-bot: I haz the power, 2017-02-24 09:30:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f20...

[kthelgason, 2017-02-24 09:55:49]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2714123002/ by kthelgason@webrtc.org.

The reason for reverting is: Breaks buildbot.

[Taylor Brandstetter, 2017-02-24 09:58:56]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-24 09:58:56]

It looks like there are still "unused variable" compile warnings:
https://build.chromium.org/p/client.webrtc/builders/Mac64%20Release/builds/11...