Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2718653002: Reland of move some warning suppressions from SocketRocket. (Closed)

Created:
3 years, 10 months ago by kthelgason
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2714123002/ ) Reason for revert: Buildbot issues have been fixed. Original issue's description: > Revert of Remove some warning suppressions from SocketRocket. (patchset #1 id:1 of https://codereview.webrtc.org/2704383004/ ) > > Reason for revert: > Breaks buildbot > > Original issue's description: > > Remove some warning suppressions from SocketRocket. > > > > These warnings started appearing on a clang update. This CL patches the > > vendored library and removes the supression. We assert on the return as > > we're not equipped to deal with failures there anyway. > > > > BUG=webrtc:6396 > > NOTRY=true > > > > Review-Url: https://codereview.webrtc.org/2704383004 > > Cr-Commit-Position: refs/heads/master@{#16820} > > Committed: https://chromium.googlesource.com/external/webrtc/+/49990e88fb523901b28d10f2026602cb86528b0d > > TBR=kjellander@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6396 > > Review-Url: https://codereview.webrtc.org/2714123002 > Cr-Commit-Position: refs/heads/master@{#16822} > Committed: https://chromium.googlesource.com/external/webrtc/+/e47de1a69c2f574d71728b16825f8cdbf7407481 TBR=kjellander@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6396 Review-Url: https://codereview.webrtc.org/2718653002 Cr-Commit-Position: refs/heads/master@{#16823} Committed: https://chromium.googlesource.com/external/webrtc/+/00df91ce50c71b7895ec24246c71c08568236967

Patch Set 1 #

Patch Set 2 : add back -Wno-unused-variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M webrtc/examples/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/examples/objc/AppRTCMobile/third_party/SocketRocket/SRWebSocket.m View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kthelgason
Created Reland of move some warning suppressions from SocketRocket.
3 years, 10 months ago (2017-02-24 10:03:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718653002/70001
3 years, 10 months ago (2017-02-24 10:08:13 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:70001) as https://chromium.googlesource.com/external/webrtc/+/00df91ce50c71b7895ec24246c71c08568236967
3 years, 10 months ago (2017-02-24 10:08:22 UTC) #6
kjellander_webrtc
I haven't looked super-close, but isn't this identical to https://codereview.webrtc.org/2704383004 ? What buildbot issues?
3 years, 10 months ago (2017-02-24 11:06:09 UTC) #7
kthelgason
3 years, 10 months ago (2017-02-24 16:06:01 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:70001) has been created in
https://codereview.webrtc.org/2718703002/ by kthelgason@webrtc.org.

The reason for reverting is: Breaks AppRTCMobile in release configuration.

Powered by Google App Engine
This is Rietveld 408576698