Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2718383002: Rename RTCCodecStats.codec -> mimeType, parameters -> sdpFmtpLine. (Closed)

Created:
3 years, 9 months ago by hbos
Modified:
3 years, 9 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename RTCCodecStats.codec -> mimeType, parameters -> sdpFmtpLine. As per https://github.com/w3c/webrtc-stats/pull/168. NOTRY due to broken linux_ubsan_vptr, all other tests passed. BUG=webrtc:7061 NOTRY=True Review-Url: https://codereview.webrtc.org/2718383002 Cr-Commit-Position: refs/heads/master@{#16907} Committed: https://chromium.googlesource.com/external/webrtc/+/13f54b2c5684119a1b31f172b3745cbec7229ebb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hbos
Please take a look, hta.
3 years, 9 months ago (2017-02-28 13:45:24 UTC) #4
hta-webrtc
lgtm
3 years, 9 months ago (2017-02-28 14:24:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718383002/1
3 years, 9 months ago (2017-02-28 14:54:12 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 14:56:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/13f54b2c5684119a1b31f172b...

Powered by Google App Engine
This is Rietveld 408576698