Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2718383002: Rename RTCCodecStats.codec -> mimeType, parameters -> sdpFmtpLine. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/pc/rtcstatscollector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 verifier.TestMemberIsDefined(certificate.base64_certificate); 327 verifier.TestMemberIsDefined(certificate.base64_certificate);
328 verifier.TestMemberIsOptionalIDReference( 328 verifier.TestMemberIsOptionalIDReference(
329 certificate.issuer_certificate_id, RTCCertificateStats::kType); 329 certificate.issuer_certificate_id, RTCCertificateStats::kType);
330 return verifier.ExpectAllMembersSuccessfullyTested(); 330 return verifier.ExpectAllMembersSuccessfullyTested();
331 } 331 }
332 332
333 bool VerifyRTCCodecStats( 333 bool VerifyRTCCodecStats(
334 const RTCCodecStats& codec) { 334 const RTCCodecStats& codec) {
335 RTCStatsVerifier verifier(report_, &codec); 335 RTCStatsVerifier verifier(report_, &codec);
336 verifier.TestMemberIsDefined(codec.payload_type); 336 verifier.TestMemberIsDefined(codec.payload_type);
337 verifier.TestMemberIsDefined(codec.codec); 337 verifier.TestMemberIsDefined(codec.mime_type);
338 verifier.TestMemberIsPositive<uint32_t>(codec.clock_rate); 338 verifier.TestMemberIsPositive<uint32_t>(codec.clock_rate);
339 verifier.TestMemberIsUndefined(codec.channels); 339 verifier.TestMemberIsUndefined(codec.channels);
340 verifier.TestMemberIsUndefined(codec.parameters); 340 verifier.TestMemberIsUndefined(codec.sdp_fmtp_line);
341 verifier.TestMemberIsUndefined(codec.implementation); 341 verifier.TestMemberIsUndefined(codec.implementation);
342 return verifier.ExpectAllMembersSuccessfullyTested(); 342 return verifier.ExpectAllMembersSuccessfullyTested();
343 } 343 }
344 344
345 bool VerifyRTCDataChannelStats( 345 bool VerifyRTCDataChannelStats(
346 const RTCDataChannelStats& data_channel) { 346 const RTCDataChannelStats& data_channel) {
347 RTCStatsVerifier verifier(report_, &data_channel); 347 RTCStatsVerifier verifier(report_, &data_channel);
348 verifier.TestMemberIsDefined(data_channel.label); 348 verifier.TestMemberIsDefined(data_channel.label);
349 verifier.TestMemberIsDefined(data_channel.protocol); 349 verifier.TestMemberIsDefined(data_channel.protocol);
350 verifier.TestMemberIsDefined(data_channel.datachannelid); 350 verifier.TestMemberIsDefined(data_channel.datachannelid);
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 // Any pending stats requests should have completed in the act of destroying 645 // Any pending stats requests should have completed in the act of destroying
646 // the peer connection. 646 // the peer connection.
647 EXPECT_TRUE(stats_obtainer->report()); 647 EXPECT_TRUE(stats_obtainer->report());
648 } 648 }
649 #endif // HAVE_SCTP 649 #endif // HAVE_SCTP
650 #endif // !defined(THREAD_SANITIZER) 650 #endif // !defined(THREAD_SANITIZER)
651 651
652 } // namespace 652 } // namespace
653 653
654 } // namespace webrtc 654 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/stats/rtcstats_objects.h ('k') | webrtc/pc/rtcstatscollector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698