Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2718383002: Rename RTCCodecStats.codec -> mimeType, parameters -> sdpFmtpLine. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/pc/rtcstats_integrationtest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 class RTCCodecStats final : public RTCStats { 80 class RTCCodecStats final : public RTCStats {
81 public: 81 public:
82 WEBRTC_RTCSTATS_DECL(); 82 WEBRTC_RTCSTATS_DECL();
83 83
84 RTCCodecStats(const std::string& id, int64_t timestamp_us); 84 RTCCodecStats(const std::string& id, int64_t timestamp_us);
85 RTCCodecStats(std::string&& id, int64_t timestamp_us); 85 RTCCodecStats(std::string&& id, int64_t timestamp_us);
86 RTCCodecStats(const RTCCodecStats& other); 86 RTCCodecStats(const RTCCodecStats& other);
87 ~RTCCodecStats() override; 87 ~RTCCodecStats() override;
88 88
89 RTCStatsMember<uint32_t> payload_type; 89 RTCStatsMember<uint32_t> payload_type;
90 RTCStatsMember<std::string> codec; 90 RTCStatsMember<std::string> mime_type;
91 RTCStatsMember<uint32_t> clock_rate; 91 RTCStatsMember<uint32_t> clock_rate;
92 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061 92 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
93 RTCStatsMember<uint32_t> channels; 93 RTCStatsMember<uint32_t> channels;
94 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061 94 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
95 RTCStatsMember<std::string> parameters; 95 RTCStatsMember<std::string> sdp_fmtp_line;
96 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061 96 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
97 RTCStatsMember<std::string> implementation; 97 RTCStatsMember<std::string> implementation;
98 }; 98 };
99 99
100 // https://w3c.github.io/webrtc-stats/#dcstats-dict* 100 // https://w3c.github.io/webrtc-stats/#dcstats-dict*
101 class RTCDataChannelStats final : public RTCStats { 101 class RTCDataChannelStats final : public RTCStats {
102 public: 102 public:
103 WEBRTC_RTCSTATS_DECL(); 103 WEBRTC_RTCSTATS_DECL();
104 104
105 RTCDataChannelStats(const std::string& id, int64_t timestamp_us); 105 RTCDataChannelStats(const std::string& id, int64_t timestamp_us);
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"? 407 // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"?
408 RTCStatsMember<std::string> dtls_state; 408 RTCStatsMember<std::string> dtls_state;
409 RTCStatsMember<std::string> selected_candidate_pair_id; 409 RTCStatsMember<std::string> selected_candidate_pair_id;
410 RTCStatsMember<std::string> local_certificate_id; 410 RTCStatsMember<std::string> local_certificate_id;
411 RTCStatsMember<std::string> remote_certificate_id; 411 RTCStatsMember<std::string> remote_certificate_id;
412 }; 412 };
413 413
414 } // namespace webrtc 414 } // namespace webrtc
415 415
416 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 416 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/pc/rtcstats_integrationtest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698