Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2718013002: Reland of Set scaling limit at 320 * 180 for all implementations. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Set scaling limit at 320 * 180 for all implementations. (patchset #1 id:1 of https://codereview.webrtc.org/2711913007/ ) Reason for revert: Reland after fixing broken perf tests. Original issue's description: > Revert of Set scaling limit at 320 * 180 for all implementations. (patchset #2 id:20001 of https://codereview.webrtc.org/2709153002/ ) > > Reason for revert: > Looks like webrtc_perf_test started failing on linux, mac and windows after this cl landed. > > Example failure: > > https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/1386/steps/webrtc_perf_tests/logs/stdio > > [ RUN ] CallPerfTest.ReceivesCpuOveruseAndUnderuse > ../../webrtc/call/call_perf_tests.cc:522: Failure > Value of: Wait() > Actual: false > Expected: true > Timed out before receiving an overuse callback. > [ FAILED ] CallPerfTest.ReceivesCpuOveruseAndUnderuse (120056 ms) > > > Original issue's description: > > Set scaling limit at 320 * 180 for all implementations. > > > > The MediaCodec decoder on android has trouble decoding video at > > so low resolutions. We set the limit a bit higher for all implementations > > pending a robust software fallback implementation for MediaCodec. > > > > BUG=webrtc:7206 > > > > Review-Url: https://codereview.webrtc.org/2709153002 > > Cr-Commit-Position: refs/heads/master@{#16798} > > Committed: https://chromium.googlesource.com/external/webrtc/+/560ddb7321f2ae42ff1eb4c79d7c65d59f61dfe2 > > TBR=magjed@webrtc.org,sprang@webrtc.org,kthelgason@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7206 > > Review-Url: https://codereview.webrtc.org/2711913007 > Cr-Commit-Position: refs/heads/master@{#16839} > Committed: https://chromium.googlesource.com/external/webrtc/+/37510bf0946afef1015eabb66a801af3ac30042a TBR=magjed@webrtc.org,sprang@webrtc.org,tommi@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7206 Review-Url: https://codereview.webrtc.org/2718013002 Cr-Commit-Position: refs/heads/master@{#16853} Committed: https://chromium.googlesource.com/external/webrtc/+/fa5fdce1009619d4ada99d74d066834fd66d3f40

Patch Set 1 #

Patch Set 2 : Fix perf tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kthelgason
Created Reland of Set scaling limit at 320 * 180 for all implementations.
3 years, 9 months ago (2017-02-27 07:35:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2718013002/40001
3 years, 9 months ago (2017-02-27 07:58:52 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 08:15:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/fa5fdce1009619d4ada99d74d...

Powered by Google App Engine
This is Rietveld 408576698