Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2709153002: Set scaling limit at 320 * 180 for all implementations. (Closed)

Created:
3 years, 10 months ago by kthelgason
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set scaling limit at 320 * 180 for all implementations. The MediaCodec decoder on android has trouble decoding video at so low resolutions. We set the limit a bit higher for all implementations pending a robust software fallback implementation for MediaCodec. BUG=webrtc:7206 Review-Url: https://codereview.webrtc.org/2709153002 Cr-Commit-Position: refs/heads/master@{#16798} Committed: https://chromium.googlesource.com/external/webrtc/+/560ddb7321f2ae42ff1eb4c79d7c65d59f61dfe2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add bug ref to comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M webrtc/video/vie_encoder.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
kthelgason
+sprang for owner review.
3 years, 10 months ago (2017-02-22 07:58:52 UTC) #4
magjed_webrtc
lgtm https://codereview.webrtc.org/2709153002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/2709153002/diff/1/webrtc/video/vie_encoder.cc#newcode41 webrtc/video/vie_encoder.cc:41: // on MediaCodec and fallback implementations are in ...
3 years, 10 months ago (2017-02-22 14:12:45 UTC) #7
kthelgason
ping erik: can we get this landed asap? It fixes a P1
3 years, 10 months ago (2017-02-23 09:55:08 UTC) #8
kthelgason
ping erik: can we get this landed asap? It fixes a P1
3 years, 10 months ago (2017-02-23 09:55:12 UTC) #9
sprang_webrtc
lgtm with magjeds comment fixed
3 years, 10 months ago (2017-02-23 10:09:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2709153002/20001
3 years, 10 months ago (2017-02-23 10:38:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/560ddb7321f2ae42ff1eb4c79d7c65d59f61dfe2
3 years, 10 months ago (2017-02-23 11:22:08 UTC) #16
tommi
3 years, 10 months ago (2017-02-25 18:28:31 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2711913007/ by tommi@webrtc.org.

The reason for reverting is: Looks like webrtc_perf_test started failing on
linux, mac and windows after this cl landed.

Example failure:

https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/build...

[ RUN      ] CallPerfTest.ReceivesCpuOveruseAndUnderuse
../../webrtc/call/call_perf_tests.cc:522: Failure
Value of: Wait()
  Actual: false
Expected: true
Timed out before receiving an overuse callback.
[  FAILED  ] CallPerfTest.ReceivesCpuOveruseAndUnderuse (120056 ms)
.

Powered by Google App Engine
This is Rietveld 408576698