Chromium Code Reviews

Issue 2711913007: Revert of Set scaling limit at 320 * 180 for all implementations. (Closed)

Created:
3 years, 10 months ago by tommi
Modified:
3 years, 10 months ago
Reviewers:
magjed_webrtc, kthelgason, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Set scaling limit at 320 * 180 for all implementations. (patchset #2 id:20001 of https://codereview.webrtc.org/2709153002/ ) Reason for revert: Looks like webrtc_perf_test started failing on linux, mac and windows after this cl landed. Example failure: https://build.chromium.org/p/client.webrtc.perf/builders/Linux%20Trusty/builds/1386/steps/webrtc_perf_tests/logs/stdio [ RUN ] CallPerfTest.ReceivesCpuOveruseAndUnderuse ../../webrtc/call/call_perf_tests.cc:522: Failure Value of: Wait() Actual: false Expected: true Timed out before receiving an overuse callback. [ FAILED ] CallPerfTest.ReceivesCpuOveruseAndUnderuse (120056 ms) Original issue's description: > Set scaling limit at 320 * 180 for all implementations. > > The MediaCodec decoder on android has trouble decoding video at > so low resolutions. We set the limit a bit higher for all implementations > pending a robust software fallback implementation for MediaCodec. > > BUG=webrtc:7206 > > Review-Url: https://codereview.webrtc.org/2709153002 > Cr-Commit-Position: refs/heads/master@{#16798} > Committed: https://chromium.googlesource.com/external/webrtc/+/560ddb7321f2ae42ff1eb4c79d7c65d59f61dfe2 TBR=magjed@webrtc.org,sprang@webrtc.org,kthelgason@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7206 Review-Url: https://codereview.webrtc.org/2711913007 Cr-Commit-Position: refs/heads/master@{#16839} Committed: https://chromium.googlesource.com/external/webrtc/+/37510bf0946afef1015eabb66a801af3ac30042a

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -2 lines)
M webrtc/video/vie_encoder.cc View 1 chunk +4 lines, -2 lines 0 comments

Messages

Total messages: 7 (3 generated)
tommi
Created Revert of Set scaling limit at 320 * 180 for all implementations.
3 years, 10 months ago (2017-02-25 18:28:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2711913007/1
3 years, 10 months ago (2017-02-25 18:28:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/37510bf0946afef1015eabb66a801af3ac30042a
3 years, 10 months ago (2017-02-25 19:31:00 UTC) #6
kthelgason
3 years, 9 months ago (2017-02-27 07:35:10 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2718013002/ by kthelgason@webrtc.org.

The reason for reverting is: Reland after fixing broken perf tests..

Powered by Google App Engine