Evaluation controller, evaluation score abstract class, and score data access.

Evaluation controller, evaluation score abstract class, and score data access.

BUG=webrtc:7218
Review-Url: https://codereview.webrtc.org/2714543005
Cr-Commit-Position: refs/heads/master@{#17012}
Committed: https://chromium.googlesource.com/external/webrtc/+/bf4007dbe995a5eb17222507fd8400c081f997f8

[AleBzk, 2017-02-24 14:15:06]

Description was changed from

==========
Evaluation controller, evaluation score abstract class, and score data access.

BUG=webrtc:7218
==========

to

==========
Evaluation controller, evaluation score abstract class, and score data access.

BUG=webrtc:7218
==========

[AleBzk, 2017-02-24 14:15:06]

alessiob@webrtc.org changed reviewers:
+ aleloi@webrtc.org, ivoc@webrtc.org

[AleBzk, 2017-02-28 16:11:53]

alessiob@webrtc.org changed reviewers:
- ivoc@webrtc.org

[AleBzk, 2017-02-28 16:11:54]

The evaluation controller is responsible for iterating over the evaluation
scores to compute, the evaluation score abstract class provides interface and
common methods with which scores (e.g., POLQA) are implemented. The CL also
includes a simple data access module.

[aleloi2, 2017-03-02 17:41:52]

On 2017/02/28 16:11:54, AleBzk wrote:
> The evaluation controller is responsible for iterating over the evaluation
> scores to compute, the evaluation score abstract class provides interface and
> common methods with which scores (e.g., POLQA) are implemented. The CL also
> includes a simple data access module.

This would be a good CL description.

[aleloi2, 2017-03-02 17:42:22]

aleloi@google.com changed reviewers:
+ aleloi@google.com

[aleloi2, 2017-03-02 17:42:23]

LGTM.

https://codereview.webrtc.org/2714543005/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py
(right):

https://codereview.webrtc.org/2714543005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py:23:
self._tested_signal = None
Question: what will the _*_signal members contain? Some kind of wav file wrapper
object?

https://codereview.webrtc.org/2714543005/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/evaluation.py
(right):

https://codereview.webrtc.org/2714543005/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/evaluation.py:18:
reference_input_filepath, output_path):
Why is it called reference_input? Since it's compared to output, why is it not
reference_output?

[AleBzk, 2017-03-03 15:02:59]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-03-03 15:02:59]

The patchset sent to the CQ was uploaded after l-g-t-m from aleloi@google.com
Link to the patchset: https://codereview.webrtc.org/2714543005/#ps20001 (title:
"Downgrading to Python 2")

[commit-bot: I haz the power, 2017-03-03 15:03:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 15:59:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488553379575290,
"parent_rev": "930ff23261b4cfd900a7c83ab7cbcff80d27fa6a", "commit_rev":
"bf4007dbe995a5eb17222507fd8400c081f997f8"}

[commit-bot: I haz the power, 2017-03-03 15:59:33]

Description was changed from

==========
Evaluation controller, evaluation score abstract class, and score data access.

BUG=webrtc:7218
==========

to

==========
Evaluation controller, evaluation score abstract class, and score data access.

BUG=webrtc:7218

Review-Url: https://codereview.webrtc.org/2714543005
Cr-Commit-Position: refs/heads/master@{#17012}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bf4007dbe995a5eb17222507f...
==========

[commit-bot: I haz the power, 2017-03-03 15:59:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/bf4007dbe995a5eb17222507f...