APM configuration files generator.

APM configuration files generator.
It generates json files to be used as APM configuration presets.
Useful to avoid manual editing of such files.

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2719853006
Cr-Commit-Position: refs/heads/master@{#17013}
Committed: https://chromium.googlesource.com/external/webrtc/+/446fb136dc5ec7c350e528363ec8c116f7e256ed

[AleBzk, 2017-02-28 10:03:13]

Description was changed from

==========
APM configuration files generator.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
APM configuration files generator.

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-02-28 10:03:13]

alessiob@webrtc.org changed reviewers:
+ aleloi@webrtc.org

[AleBzk, 2017-02-28 10:05:06]

Hi Alex, this CL should be reviewed by you since you recently changed
audioproc_f. It is a simple script that generates audioproc_f command line
arguments (to setup APM).

[aleloi2, 2017-03-02 01:29:50]

aleloi@google.com changed reviewers:
+ aleloi@google.com

[aleloi2, 2017-03-02 01:29:51]

Great with short CLs!

LG modulo a few comments. In general LGTM (but please fix the comments) so you
don't have to wait until I'm online again.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py
(right):

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:21:
def _generate_default_overridden(CONFIG_OVERRIDE):
Does whichever py style doc we use say something about naming? I've never seen
function arguments in caps.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:23:
Default settings from
Please update the docstring to explain the params and behavior more. The fact
that it writes files should be mentioned.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:71:
Generate configuratoins in which all the default flags are used and each
configuratoins

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:78:
#    '-bf': 1, '-mic_positions': '-0.15 0.3 0.3 0.15 0.3 0.3'},
Why comment?

[AleBzk, 2017-03-02 09:08:58]

Hi Alex,
Thanks for your comments.
Everything has been addressed.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
File
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py
(right):

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:21:
def _generate_default_overridden(CONFIG_OVERRIDE):
On 2017/03/02 01:29:51, aleloi2 wrote:
> Does whichever py style doc we use say something about naming? I've never seen
> function arguments in caps.

Right, I'll make it lowercase.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:23:
Default settings from
On 2017/03/02 01:29:51, aleloi2 wrote:
> Please update the docstring to explain the params and behavior more. The fact
> that it writes files should be mentioned.

Acknowledged.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:71:
Generate configuratoins in which all the default flags are used and each
On 2017/03/02 01:29:51, aleloi2 wrote:
> configuratoins

Acknowledged.

https://codereview.webrtc.org/2719853006/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:78:
#    '-bf': 1, '-mic_positions': '-0.15 0.3 0.3 0.15 0.3 0.3'},
On 2017/03/02 01:29:51, aleloi2 wrote:
> Why comment?

Let me remove this for the time being.
Beam forming requires multiple channel input which is not supported by my tool
yet.

[aleloi2, 2017-03-02 17:00:01]

Another thing: can you please elaborate a little more in the CL description?
What and why and how it fits with the rest.

https://codereview.webrtc.org/2719853006/diff/20001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py
(right):

https://codereview.webrtc.org/2719853006/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment-gencfgs.py:76:
Generate configuratoins in which all the default flags are used and each
Still configuratoins. But you fixed the other one that I didn't spot :)

[AleBzk, 2017-03-03 15:05:23]

Description was changed from

==========
APM configuration files generator.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
APM configuration files generator.
It generates json files to be used as APM configuration presets.
Useful to avoid manual editing of such files.

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-03-03 16:18:20]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-03-03 16:18:21]

The patchset sent to the CQ was uploaded after l-g-t-m from aleloi@google.com
Link to the patchset: https://codereview.webrtc.org/2719853006/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2017-03-03 16:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 16:20:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488557900934490,
"parent_rev": "bf4007dbe995a5eb17222507fd8400c081f997f8", "commit_rev":
"446fb136dc5ec7c350e528363ec8c116f7e256ed"}

[commit-bot: I haz the power, 2017-03-03 16:20:23]

Description was changed from

==========
APM configuration files generator.
It generates json files to be used as APM configuration presets.
Useful to avoid manual editing of such files.

BUG=webrtc:7218
NOTRY=True
==========

to

==========
APM configuration files generator.
It generates json files to be used as APM configuration presets.
Useful to avoid manual editing of such files.

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2719853006
Cr-Commit-Position: refs/heads/master@{#17013}
Committed:
https://chromium.googlesource.com/external/webrtc/+/446fb136dc5ec7c350e528363...
==========

[commit-bot: I haz the power, 2017-03-03 16:20:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/446fb136dc5ec7c350e528363...