APM Quality Assessment tool, audioproc_f Python wrapper

"audioproc_f" wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2711313004
Cr-Commit-Position: refs/heads/master@{#17008}
Committed: https://chromium.googlesource.com/external/webrtc/+/b4ec8765d8a61f2423364d2729670427bebb2518

[AleBzk, 2017-02-24 13:42:18]

Description was changed from

==========
audioproc_f wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
==========

to

==========
audioproc_f wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
==========

[AleBzk, 2017-02-24 13:42:18]

alessiob@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[AleBzk, 2017-02-24 13:42:58]

Description was changed from

==========
audioproc_f wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
==========

to

==========
"audioproc_f" wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
==========

[AleBzk, 2017-02-24 13:42:58]

alessiob@webrtc.org changed reviewers:
+ aleloi@webrtc.org

[AleBzk, 2017-02-24 13:44:16]

Python wrapper of the audioproc_f tool.

[AleBzk, 2017-02-27 15:45:48]

Sorry about the multiple patches (they're all the same). Just check the most
recent.

[ivoc, 2017-03-02 00:38:19]

LGTM, but please improve your CL description with a subject/summary line and
some text to explain what it does. Also, see some comments below.

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py
(right):

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py:9:
import cProfile
in C++ we always order the includes alphabetically. Maybe we should do the same
in python?

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py:19:

Remove blank line please.

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py
(right):

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:35:
Metadata loader for input and reference audio track peths.
paths

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:47:
Metadata saver for input and reference audio track peths.
paths

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:56:
Data access class to save and load audioproc_f arguments lists to control
argument lists

[AleBzk, 2017-03-02 10:00:07]

Description was changed from

==========
"audioproc_f" wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
==========

to

==========
"audioproc_f" wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
NOTRY=True
==========

[AleBzk, 2017-03-02 10:23:09]

alessiob@webrtc.org changed reviewers:
- aleloi@webrtc.org

[AleBzk, 2017-03-02 10:23:11]

Thanks for your comments Ivo!

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py
(right):

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py:9:
import cProfile
On 2017/03/02 00:38:19, ivoc wrote:
> in C++ we always order the includes alphabetically. Maybe we should do the
same
> in python?

Thanks Ivo!
The Python style guide indicates to group first and then use alphabetical order:
https://engdoc.corp.google.com/eng/doc/devguide/py/styleguide.shtml?cl=head#i...

The first group is standard libraries (e.g., os), the second is third-party
(e.g., scipy - missing in this file), and finally third and fourth for "custom"
modules (i.e., code we add in the WebRTC repo).

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py:9:
import cProfile
On 2017/03/02 00:38:19, ivoc wrote:
> in C++ we always order the includes alphabetically. Maybe we should do the
same
> in python?

Acknowledged.

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/audioproc_wrapper.py:19:

On 2017/03/02 00:38:19, ivoc wrote:
> Remove blank line please.

Done.

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
File
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py
(right):

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:35:
Metadata loader for input and reference audio track peths.
On 2017/03/02 00:38:19, ivoc wrote:
> paths

Pets would have been a nice alternative too :D

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:35:
Metadata loader for input and reference audio track peths.
On 2017/03/02 00:38:19, ivoc wrote:
> paths

Done.

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:47:
Metadata saver for input and reference audio track peths.
On 2017/03/02 00:38:19, ivoc wrote:
> paths

Done.

https://codereview.webrtc.org/2711313004/diff/60001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py:56:
Data access class to save and load audioproc_f arguments lists to control
On 2017/03/02 00:38:19, ivoc wrote:
> argument lists

Done.

[aleloi2, 2017-03-02 17:05:21]

On 2017/02/27 15:45:48, AleBzk wrote:
> Sorry about the multiple patches (they're all the same). Just check the most
> recent.

There is a feature that deletes a patch. The link is above to the right of the
list of changed files. It's safe meaning that nothing will break if you remove
patches 1, 2, 3 of 5. Just please don't delete patches with reviewer comments in
them.

[aleloi2, 2017-03-02 17:05:28]

On 2017/02/27 15:45:48, AleBzk wrote:
> Sorry about the multiple patches (they're all the same). Just check the most
> recent.

There is a feature that deletes a patch. The link is above to the right of the
list of changed files. It's safe meaning that nothing will break if you remove
patches 1, 2, 3 of 5. Just please don't delete patches with reviewer comments in
them.

[ivoc, 2017-03-02 19:13:53]

Great, still lgtm :)

[AleBzk, 2017-03-03 14:51:35]

The CQ bit was checked by alessiob@webrtc.org

[AleBzk, 2017-03-03 14:51:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2711313004/#ps100001 (title:
"rebase")

[commit-bot: I haz the power, 2017-03-03 14:51:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 14:53:56]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488552695379270,
"parent_rev": "a4b1d31207a9d73ec9c85a443375d1ba575fea55", "commit_rev":
"b4ec8765d8a61f2423364d2729670427bebb2518"}

[commit-bot: I haz the power, 2017-03-03 14:53:58]

Description was changed from

==========
"audioproc_f" wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
NOTRY=True
==========

to

==========
"audioproc_f" wrapper
- Metadata and AudioProcConfigFile classes
- ApmModuleSimulator constructor updated
- BUILD.gn updated

BUG=webrtc:7218
NOTRY=True

Review-Url: https://codereview.webrtc.org/2711313004
Cr-Commit-Position: refs/heads/master@{#17008}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b4ec8765d8a61f2423364d272...
==========

[commit-bot: I haz the power, 2017-03-03 14:54:00]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/b4ec8765d8a61f2423364d272...