Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2691933003: Improve warning about deprecation in PRESUBMIT (Closed)

Created:
3 years, 10 months ago by oprypin_webrtc
Modified:
3 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improve warning about deprecation in PRESUBMIT BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2691933003 Cr-Commit-Position: refs/heads/master@{#16575} Committed: https://chromium.googlesource.com/external/webrtc/+/375b9ac4cc05e344af541c35a66c03feebbf7748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
oprypin_webrtc
3 years, 10 months ago (2017-02-13 11:30:54 UTC) #2
kjellander_webrtc
lgtm I added NOTRY=True for you (it doesn't make sense to run compile or tests ...
3 years, 10 months ago (2017-02-13 11:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2691933003/1
3 years, 10 months ago (2017-02-13 12:10:49 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 12:13:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/375b9ac4cc05e344af541c35a...

Powered by Google App Engine
This is Rietveld 408576698