PRESUBMIT.py - Issue 2691933003: Improve warning about deprecation in PRESUBMIT - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(72)

My Issues | Starred Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2691933003: Improve warning about deprecation in PRESUBMIT (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 6e5fb591cf18272483b194c27e678a8e7f839e0a..3405ef9116fcd9e654af577ba49538e08ca945d3 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -117,8 +117,9 @@ def _VerifyNativeApiHeadersListIsValid(input_api, output_api):

api_change_msg = """

You seem to be changing native API header files. Please make sure that you:

- 1. Make compatible changes that don't break existing clients.

- 2. Mark the old stuff as deprecated.

+ 1. Make compatible changes that don't break existing clients. Usually

+ this is done by keeping the existing method signatures unchanged.

+ 2. Mark the old stuff as deprecated (see RTC_DEPRECATED macro).

3. Create a timeline and plan for when the deprecated stuff will be

removed. (The amount of time we give users to change their code

should be informed by how much work it is for them. If they just

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698