OLD | NEW |
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
2 # | 2 # |
3 # Use of this source code is governed by a BSD-style license | 3 # Use of this source code is governed by a BSD-style license |
4 # that can be found in the LICENSE file in the root of the source | 4 # that can be found in the LICENSE file in the root of the source |
5 # tree. An additional intellectual property rights grant can be found | 5 # tree. An additional intellectual property rights grant can be found |
6 # in the file PATENTS. All contributing project authors may | 6 # in the file PATENTS. All contributing project authors may |
7 # be found in the AUTHORS file in the root of the source tree. | 7 # be found in the AUTHORS file in the root of the source tree. |
8 | 8 |
9 import json | 9 import json |
10 import os | 10 import os |
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
110 if non_existing_paths: | 110 if non_existing_paths: |
111 return [output_api.PresubmitError( | 111 return [output_api.PresubmitError( |
112 'Directories to native API headers have changed which has made the ' | 112 'Directories to native API headers have changed which has made the ' |
113 'list in PRESUBMIT.py outdated.\nPlease update it to the current ' | 113 'list in PRESUBMIT.py outdated.\nPlease update it to the current ' |
114 'location of our native APIs.', | 114 'location of our native APIs.', |
115 non_existing_paths)] | 115 non_existing_paths)] |
116 return [] | 116 return [] |
117 | 117 |
118 api_change_msg = """ | 118 api_change_msg = """ |
119 You seem to be changing native API header files. Please make sure that you: | 119 You seem to be changing native API header files. Please make sure that you: |
120 1. Make compatible changes that don't break existing clients. | 120 1. Make compatible changes that don't break existing clients. Usually |
121 2. Mark the old stuff as deprecated. | 121 this is done by keeping the existing method signatures unchanged. |
| 122 2. Mark the old stuff as deprecated (see RTC_DEPRECATED macro). |
122 3. Create a timeline and plan for when the deprecated stuff will be | 123 3. Create a timeline and plan for when the deprecated stuff will be |
123 removed. (The amount of time we give users to change their code | 124 removed. (The amount of time we give users to change their code |
124 should be informed by how much work it is for them. If they just | 125 should be informed by how much work it is for them. If they just |
125 need to replace one name with another or something equally | 126 need to replace one name with another or something equally |
126 simple, 1-2 weeks might be good; if they need to do serious work, | 127 simple, 1-2 weeks might be good; if they need to do serious work, |
127 up to 3 months may be called for.) | 128 up to 3 months may be called for.) |
128 4. Update/inform existing downstream code owners to stop using the | 129 4. Update/inform existing downstream code owners to stop using the |
129 deprecated stuff. (Send announcements to | 130 deprecated stuff. (Send announcements to |
130 discuss-webrtc@googlegroups.com and webrtc-users@google.com.) | 131 discuss-webrtc@googlegroups.com and webrtc-users@google.com.) |
131 5. Remove the deprecated stuff, once the agreed-upon amount of time | 132 5. Remove the deprecated stuff, once the agreed-upon amount of time |
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
538 input_api, output_api)) | 539 input_api, output_api)) |
539 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 540 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
540 input_api, output_api)) | 541 input_api, output_api)) |
541 results.extend(_CheckChangeHasBugField(input_api, output_api)) | 542 results.extend(_CheckChangeHasBugField(input_api, output_api)) |
542 results.extend(input_api.canned_checks.CheckChangeHasTestField( | 543 results.extend(input_api.canned_checks.CheckChangeHasTestField( |
543 input_api, output_api)) | 544 input_api, output_api)) |
544 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 545 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
545 input_api, output_api, | 546 input_api, output_api, |
546 json_url='http://webrtc-status.appspot.com/current?format=json')) | 547 json_url='http://webrtc-status.appspot.com/current?format=json')) |
547 return results | 548 return results |
OLD | NEW |