Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2684023002: Remove repeat flag from SendRTCP (Closed)

Created:
3 years, 10 months ago by danilchap
Modified:
3 years, 10 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove repeat flag from SendRTCP It is always false BUG=webrtc:5565 Review-Url: https://codereview.webrtc.org/2684023002 Cr-Commit-Position: refs/heads/master@{#16491} Committed: https://chromium.googlesource.com/external/webrtc/+/498ee8e816a9f900f0904319d899cecde8d62b14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -34 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 5 chunks +3 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 4 chunks +3 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
danilchap
Checking history I failed to find when (and why) this flag was used last time.
3 years, 10 months ago (2017-02-08 10:42:23 UTC) #3
nisse-webrtc
lgtm. I also don't find any use in git history.
3 years, 10 months ago (2017-02-08 12:02:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2684023002/1
3 years, 10 months ago (2017-02-08 12:07:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4957)
3 years, 10 months ago (2017-02-08 12:47:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2684023002/1
3 years, 10 months ago (2017-02-08 13:22:20 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 13:24:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/498ee8e816a9f900f0904319d...

Powered by Google App Engine
This is Rietveld 408576698