Remove repeat flag from SendRTCP

webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 436 matching lines @@
   EXPECT_EQ(0U, parser()->app()->data_size());
 }
 
 TEST_F(RtcpSenderTest, SetInvalidApplicationSpecificData) {
   const uint8_t kData[] = {'t', 'e', 's', 't', 'd', 'a', 't'};
   const uint16_t kInvalidDataLength = sizeof(kData) / sizeof(kData[0]);
   EXPECT_EQ(-1, rtcp_sender_->SetApplicationSpecificData(
       0, 0, kData, kInvalidDataLength));  // Should by multiple of 4.
 }
 
-TEST_F(RtcpSenderTest, SendFirNonRepeat) {
+TEST_F(RtcpSenderTest, SendFir) {
   rtcp_sender_->SetRTCPStatus(RtcpMode::kReducedSize);
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpFir));
   EXPECT_EQ(1, parser()->fir()->num_packets());
   EXPECT_EQ(kSenderSsrc, parser()->fir()->sender_ssrc());
   EXPECT_EQ(1U, parser()->fir()->requests().size());
   EXPECT_EQ(kRemoteSsrc, parser()->fir()->requests()[0].ssrc);
   uint8_t seq = parser()->fir()->requests()[0].seq_nr;
-  // Sends non-repeat FIR as default.
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpFir));
   EXPECT_EQ(2, parser()->fir()->num_packets());
   EXPECT_EQ(seq + 1, parser()->fir()->requests()[0].seq_nr);
 }
 
-TEST_F(RtcpSenderTest, SendFirRepeat) {
-  rtcp_sender_->SetRTCPStatus(RtcpMode::kReducedSize);
-  EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpFir));
-  EXPECT_EQ(1, parser()->fir()->num_packets());
-  EXPECT_EQ(1U, parser()->fir()->requests().size());
-  uint8_t seq = parser()->fir()->requests()[0].seq_nr;
-  const bool kRepeat = true;
-  EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpFir, 0, nullptr,
-                                      kRepeat));
-  EXPECT_EQ(2, parser()->fir()->num_packets());
-  EXPECT_EQ(seq, parser()->fir()->requests()[0].seq_nr);
-}
-
 TEST_F(RtcpSenderTest, SendPli) {
   rtcp_sender_->SetRTCPStatus(RtcpMode::kReducedSize);
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpPli));
   EXPECT_EQ(1, parser()->pli()->num_packets());
   EXPECT_EQ(kSenderSsrc, parser()->pli()->sender_ssrc());
   EXPECT_EQ(kRemoteSsrc, parser()->pli()->media_ssrc());
 }
 
 TEST_F(RtcpSenderTest, SendRpsi) {
   const uint64_t kPictureId = 0x41;
   const int8_t kPayloadType = 100;
   rtcp_sender_->SetRTCPStatus(RtcpMode::kReducedSize);
   RTCPSender::FeedbackState feedback_state = rtp_rtcp_impl_->GetFeedbackState();
   feedback_state.send_payload_type = kPayloadType;
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state, kRtcpRpsi, 0, nullptr,
-                                      false, kPictureId));
+                                      kPictureId));
   EXPECT_EQ(1, parser()->rpsi()->num_packets());
   EXPECT_EQ(kPayloadType, parser()->rpsi()->payload_type());
   EXPECT_EQ(kPictureId, parser()->rpsi()->picture_id());
 }
 
 TEST_F(RtcpSenderTest, SendSli) {
   const uint16_t kFirstMb = 0;
   const uint16_t kNumberOfMb = 0x1FFF;
   const uint8_t kPictureId = 60;
   rtcp_sender_->SetRTCPStatus(RtcpMode::kReducedSize);
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpSli, 0, nullptr,
-                                      false, kPictureId));
+                                      kPictureId));
   EXPECT_EQ(1, parser()->sli()->num_packets());
   EXPECT_EQ(kSenderSsrc, parser()->sli()->sender_ssrc());
   EXPECT_EQ(kRemoteSsrc, parser()->sli()->media_ssrc());
   EXPECT_EQ(1U, parser()->sli()->macroblocks().size());
   EXPECT_EQ(kFirstMb, parser()->sli()->macroblocks()[0].first());
   EXPECT_EQ(kNumberOfMb, parser()->sli()->macroblocks()[0].number());
   EXPECT_EQ(kPictureId, parser()->sli()->macroblocks()[0].picture_id());
 }
 
 TEST_F(RtcpSenderTest, SendNack) {
@@ skipping 328 matching lines @@
       const rtcp::TargetBitrate::BitrateItem& item = bitrates[index];
       EXPECT_EQ(sl, item.spatial_layer);
       EXPECT_EQ(tl, item.temporal_layer);
       EXPECT_EQ(start_bitrate_bps + (tl * 20000),
                 item.target_bitrate_kbps * 1000);
     }
   }
 }
 
 }  // namespace webrtc