Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 2684023002: Remove repeat flag from SendRTCP (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 int32_t ModuleRtpRtcpImpl::RequestKeyFrame() { 766 int32_t ModuleRtpRtcpImpl::RequestKeyFrame() {
767 switch (key_frame_req_method_) { 767 switch (key_frame_req_method_) {
768 case kKeyFrameReqPliRtcp: 768 case kKeyFrameReqPliRtcp:
769 return SendRTCP(kRtcpPli); 769 return SendRTCP(kRtcpPli);
770 case kKeyFrameReqFirRtcp: 770 case kKeyFrameReqFirRtcp:
771 return SendRTCP(kRtcpFir); 771 return SendRTCP(kRtcpFir);
772 } 772 }
773 return -1; 773 return -1;
774 } 774 }
775 775
776 int32_t ModuleRtpRtcpImpl::SendRTCPSliceLossIndication( 776 int32_t ModuleRtpRtcpImpl::SendRTCPSliceLossIndication(uint8_t picture_id) {
777 const uint8_t picture_id) { 777 return rtcp_sender_.SendRTCP(GetFeedbackState(), kRtcpSli, 0, 0, picture_id);
778 return rtcp_sender_.SendRTCP(
779 GetFeedbackState(), kRtcpSli, 0, 0, false, picture_id);
780 } 778 }
781 779
782 void ModuleRtpRtcpImpl::SetUlpfecConfig(int red_payload_type, 780 void ModuleRtpRtcpImpl::SetUlpfecConfig(int red_payload_type,
783 int ulpfec_payload_type) { 781 int ulpfec_payload_type) {
784 rtp_sender_.SetUlpfecConfig(red_payload_type, ulpfec_payload_type); 782 rtp_sender_.SetUlpfecConfig(red_payload_type, ulpfec_payload_type);
785 } 783 }
786 784
787 bool ModuleRtpRtcpImpl::SetFecParameters( 785 bool ModuleRtpRtcpImpl::SetFecParameters(
788 const FecProtectionParams& delta_params, 786 const FecProtectionParams& delta_params,
789 const FecProtectionParams& key_params) { 787 const FecProtectionParams& key_params) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 *fec_rate = rtp_sender_.FecOverheadRate(); 821 *fec_rate = rtp_sender_.FecOverheadRate();
824 *nack_rate = rtp_sender_.NackOverheadRate(); 822 *nack_rate = rtp_sender_.NackOverheadRate();
825 } 823 }
826 824
827 void ModuleRtpRtcpImpl::OnRequestSendReport() { 825 void ModuleRtpRtcpImpl::OnRequestSendReport() {
828 SendRTCP(kRtcpSr); 826 SendRTCP(kRtcpSr);
829 } 827 }
830 828
831 int32_t ModuleRtpRtcpImpl::SendRTCPReferencePictureSelection( 829 int32_t ModuleRtpRtcpImpl::SendRTCPReferencePictureSelection(
832 const uint64_t picture_id) { 830 const uint64_t picture_id) {
833 return rtcp_sender_.SendRTCP( 831 return rtcp_sender_.SendRTCP(GetFeedbackState(), kRtcpRpsi, 0, 0, picture_id);
834 GetFeedbackState(), kRtcpRpsi, 0, 0, false, picture_id);
835 } 832 }
836 833
837 void ModuleRtpRtcpImpl::OnReceivedNack( 834 void ModuleRtpRtcpImpl::OnReceivedNack(
838 const std::vector<uint16_t>& nack_sequence_numbers) { 835 const std::vector<uint16_t>& nack_sequence_numbers) {
839 for (uint16_t nack_sequence_number : nack_sequence_numbers) { 836 for (uint16_t nack_sequence_number : nack_sequence_numbers) {
840 send_loss_stats_.AddLostPacket(nack_sequence_number); 837 send_loss_stats_.AddLostPacket(nack_sequence_number);
841 } 838 }
842 if (!rtp_sender_.StorePackets() || 839 if (!rtp_sender_.StorePackets() ||
843 nack_sequence_numbers.size() == 0) { 840 nack_sequence_numbers.size() == 0) {
844 return; 841 return;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 StreamDataCountersCallback* 911 StreamDataCountersCallback*
915 ModuleRtpRtcpImpl::GetSendChannelRtpStatisticsCallback() const { 912 ModuleRtpRtcpImpl::GetSendChannelRtpStatisticsCallback() const {
916 return rtp_sender_.GetRtpStatisticsCallback(); 913 return rtp_sender_.GetRtpStatisticsCallback();
917 } 914 }
918 915
919 void ModuleRtpRtcpImpl::SetVideoBitrateAllocation( 916 void ModuleRtpRtcpImpl::SetVideoBitrateAllocation(
920 const BitrateAllocation& bitrate) { 917 const BitrateAllocation& bitrate) {
921 rtcp_sender_.SetVideoBitrateAllocation(bitrate); 918 rtcp_sender_.SetVideoBitrateAllocation(bitrate);
922 } 919 }
923 } // namespace webrtc 920 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698