Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2668523004: Move AudioDecoder and related stuff to the api/ directory (Closed)

Created:
3 years, 10 months ago by kwiberg-webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, peah-webrtc, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioDecoder and related stuff to the api/ directory BUG=webrtc:5805, webrtc:6725 Review-Url: https://codereview.webrtc.org/2668523004 Cr-Commit-Position: refs/heads/master@{#16534} Committed: https://chromium.googlesource.com/external/webrtc/+/087bd34d23dee541915aae59781bf3ef033d8082

Patch Set 1 #

Patch Set 2 : Moved stuff around #

Patch Set 3 : backwards compat #

Patch Set 4 : sort #includes + git cl format #

Total comments: 58

Patch Set 5 : rebase #

Patch Set 6 : review changes #

Patch Set 7 : rebase #

Patch Set 8 : more review changes #

Total comments: 2

Patch Set 9 : new year! #

Total comments: 4

Patch Set 10 : more review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -1116 lines) Patch
M webrtc/api/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/DEPS View 1 chunk +6 lines, -4 lines 0 comments Download
A webrtc/api/audio_codecs/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +39 lines, -0 lines 0 comments Download
A + webrtc/api/audio_codecs/audio_decoder.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -6 lines 0 comments Download
A + webrtc/api/audio_codecs/audio_decoder.cc View 1 2 3 4 5 6 7 6 chunks +52 lines, -12 lines 0 comments Download
A + webrtc/api/audio_codecs/audio_decoder_factory.h View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -6 lines 0 comments Download
A + webrtc/api/audio_codecs/audio_format.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/api/audio_codecs/audio_format.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -3 lines 0 comments Download
A + webrtc/api/audio_codecs/builtin_audio_decoder_factory.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -6 lines 0 comments Download
A webrtc/api/audio_codecs/builtin_audio_decoder_factory.cc View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/audio_receive_stream.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/mediaengine.h View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M webrtc/media/engine/payload_type_mapper.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/payload_type_mapper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcmediaengine.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcmediaengine_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 4 5 6 7 8 9 26 chunks +62 lines, -64 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receive_test.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receive_test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/audio_decoder.h View 1 2 3 4 5 1 chunk +5 lines, -164 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/audio_decoder.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/audio_decoder_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -134 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/audio_format.h View 1 2 3 4 5 6 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/audio_format.cc View 1 2 3 4 5 6 1 chunk +0 lines, -86 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_format_conversion.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h View 1 2 3 4 5 1 chunk +5 lines, -12 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc View 1 2 3 4 5 6 1 chunk +0 lines, -247 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.h View 1 2 3 4 5 1 chunk +6 lines, -9 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_internal.cc View 1 2 3 4 5 6 7 3 chunks +23 lines, -20 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/audio_decoder_isac_t.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/legacy_encoded_audio_frame.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/mock/mock_audio_decoder_factory.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_decoder_opus.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/comfort_noise.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_audio_decoder.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/mock/mock_external_decoder_pcm16b.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/normal.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/packet.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/packet_buffer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/packet_buffer_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/post_decode_vad.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/red_payload_splitter_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/timestamp_scaler_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/fake_decode_from_file.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_test.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/pc/peerconnectionfactory.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M webrtc/test/call_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fuzzers/audio_decoder_fuzzer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/voice_engine/coder.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/include/voe_base.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 73 (50 generated)
kwiberg-webrtc
Still slightly rough, but please have a look. (The #includes aren't sorted yet. I'll do ...
3 years, 10 months ago (2017-02-01 00:32:50 UTC) #6
kwiberg-webrtc
OK, ready for final review now! Henrik, I'd like your input on the .gn changes ...
3 years, 10 months ago (2017-02-01 14:08:07 UTC) #32
kjellander_webrtc
I only looked at BUILD.gn files so far. https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS File webrtc/api/DEPS (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS#newcode15 webrtc/api/DEPS:15: # ...
3 years, 10 months ago (2017-02-01 14:54:50 UTC) #34
ossu
Looks pretty good. Have a few comments, though. https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/BUILD.gn File webrtc/api/audio_codec/BUILD.gn (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/BUILD.gn#newcode15 webrtc/api/audio_codec/BUILD.gn:15: rtc_source_set("audio_decoder_factory_interface") ...
3 years, 10 months ago (2017-02-01 15:05:27 UTC) #35
kwiberg-webrtc
https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS File webrtc/api/DEPS (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS#newcode15 webrtc/api/DEPS:15: # We allow .cc files in webrtc/api/ to #include ...
3 years, 10 months ago (2017-02-01 20:15:03 UTC) #38
the sun
https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/BUILD.gn File webrtc/api/BUILD.gn (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/BUILD.gn#newcode33 webrtc/api/BUILD.gn:33: "audio_codec:audio_decoder_factory_interface", nit: is this the preferred order? I'd have ...
3 years, 10 months ago (2017-02-02 21:02:29 UTC) #39
kwiberg-webrtc
New patch set uploaded. (Note that there are still a bunch of outstanding issues where ...
3 years, 10 months ago (2017-02-03 09:50:11 UTC) #42
ossu
https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS File webrtc/api/DEPS (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS#newcode15 webrtc/api/DEPS:15: # We allow .cc files in webrtc/api/ to #include ...
3 years, 10 months ago (2017-02-06 12:54:16 UTC) #45
kwiberg-webrtc
https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/BUILD.gn File webrtc/api/audio_codec/BUILD.gn (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/BUILD.gn#newcode19 webrtc/api/audio_codec/BUILD.gn:19: deps = [ On 2017/02/06 12:54:16, ossu wrote: > ...
3 years, 10 months ago (2017-02-06 14:19:36 UTC) #46
ossu
https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/audio_decoder.cc File webrtc/api/audio_codec/audio_decoder.cc (right): https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/audio_decoder.cc#newcode26 webrtc/api/audio_codec/audio_decoder.cc:26: class EncFrame final : public AudioDecoder::EncodedAudioFrame { On 2017/02/06 ...
3 years, 10 months ago (2017-02-06 14:44:07 UTC) #47
kwiberg-webrtc
I think patch set #8 fixes all issues that we've discussed. https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/audio_codec/audio_decoder.h File webrtc/api/audio_codec/audio_decoder.h (right): ...
3 years, 10 months ago (2017-02-09 20:08:30 UTC) #57
kjellander_webrtc
lgtm if you can address the downstream breakages due to the API changes. https://codereview.webrtc.org/2668523004/diff/140001/webrtc/api/DEPS File ...
3 years, 10 months ago (2017-02-10 07:58:48 UTC) #58
kwiberg-webrtc
https://codereview.webrtc.org/2668523004/diff/240001/webrtc/api/audio_codecs/builtin_audio_decoder_factory.h File webrtc/api/audio_codecs/builtin_audio_decoder_factory.h (right): https://codereview.webrtc.org/2668523004/diff/240001/webrtc/api/audio_codecs/builtin_audio_decoder_factory.h#newcode2 webrtc/api/audio_codecs/builtin_audio_decoder_factory.h:2: * Copyright (c) 2017 The WebRTC project authors. All ...
3 years, 10 months ago (2017-02-10 09:15:52 UTC) #59
kwiberg-webrtc
On 2017/02/10 07:58:48, kjellander_webrtc wrote: > lgtm if you can address the downstream breakages due ...
3 years, 10 months ago (2017-02-10 09:19:57 UTC) #60
kjellander_webrtc
On 2017/02/10 09:15:52, kwiberg-webrtc wrote: > https://codereview.webrtc.org/2668523004/diff/240001/webrtc/api/audio_codecs/builtin_audio_decoder_factory.h > File webrtc/api/audio_codecs/builtin_audio_decoder_factory.h (right): > > https://codereview.webrtc.org/2668523004/diff/240001/webrtc/api/audio_codecs/builtin_audio_decoder_factory.h#newcode2 > ...
3 years, 10 months ago (2017-02-10 09:37:45 UTC) #61
kwiberg-webrtc
On 2017/02/10 09:37:45, kjellander_webrtc wrote: > On 2017/02/10 09:15:52, kwiberg-webrtc wrote: > > > https://codereview.webrtc.org/2668523004/diff/240001/webrtc/api/audio_codecs/builtin_audio_decoder_factory.h ...
3 years, 10 months ago (2017-02-10 09:42:29 UTC) #62
the sun
lgtm https://codereview.webrtc.org/2668523004/diff/260001/webrtc/api/audio_codecs/audio_decoder_factory.h File webrtc/api/audio_codecs/audio_decoder_factory.h (right): https://codereview.webrtc.org/2668523004/diff/260001/webrtc/api/audio_codecs/audio_decoder_factory.h#newcode19 webrtc/api/audio_codecs/audio_decoder_factory.h:19: #include "webrtc/base/atomicops.h" why? https://codereview.webrtc.org/2668523004/diff/260001/webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc File webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc (right): https://codereview.webrtc.org/2668523004/diff/260001/webrtc/modules/audio_coding/codecs/audio_decoder_factory_unittest.cc#newcode2 ...
3 years, 10 months ago (2017-02-10 10:05:08 UTC) #63
the sun
On 2017/02/10 10:05:08, the sun wrote: > lgtm > > https://codereview.webrtc.org/2668523004/diff/260001/webrtc/api/audio_codecs/audio_decoder_factory.h > File webrtc/api/audio_codecs/audio_decoder_factory.h (right): ...
3 years, 10 months ago (2017-02-10 10:05:36 UTC) #64
kwiberg-webrtc
New patch set uploaded. https://codereview.webrtc.org/2668523004/diff/260001/webrtc/api/audio_codecs/audio_decoder_factory.h File webrtc/api/audio_codecs/audio_decoder_factory.h (right): https://codereview.webrtc.org/2668523004/diff/260001/webrtc/api/audio_codecs/audio_decoder_factory.h#newcode19 webrtc/api/audio_codecs/audio_decoder_factory.h:19: #include "webrtc/base/atomicops.h" On 2017/02/10 10:05:07, ...
3 years, 10 months ago (2017-02-10 11:31:24 UTC) #65
the sun
On 2017/02/10 11:31:24, kwiberg-webrtc wrote: > New patch set uploaded. > > https://codereview.webrtc.org/2668523004/diff/260001/webrtc/api/audio_codecs/audio_decoder_factory.h > File ...
3 years, 10 months ago (2017-02-10 11:55:25 UTC) #66
ossu
LGTM!
3 years, 10 months ago (2017-02-10 13:27:29 UTC) #67
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668523004/280001
3 years, 10 months ago (2017-02-10 13:29:07 UTC) #70
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 16:15:53 UTC) #73
Message was sent while issue was closed.
Committed patchset #10 (id:280001) as
https://chromium.googlesource.com/external/webrtc/+/087bd34d23dee541915aae597...

Powered by Google App Engine
This is Rietveld 408576698