Move AudioDecoder and related stuff to the api/ directory

webrtc/api/audio_codec/audio_decoder.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_AUDIO_DECODER_H_
-#define WEBRTC_MODULES_AUDIO_CODING_CODECS_AUDIO_DECODER_H_
+#ifndef WEBRTC_API_AUDIO_CODEC_AUDIO_DECODER_H_
+#define WEBRTC_API_AUDIO_CODEC_AUDIO_DECODER_H_
 
 #include <memory>
 #include <vector>
 
 #include "webrtc/base/array_view.h"
 #include "webrtc/base/buffer.h"
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/optional.h"
 #include "webrtc/typedefs.h"
 
 namespace webrtc {
 
-// This is the interface class for decoders in NetEQ. Each codec type will have
-// and implementation of this class.
 class AudioDecoder {
  public:
-  enum SpeechType {
-    kSpeech = 1,
-    kComfortNoise = 2
-  };
+  enum SpeechType { kSpeech = 1, kComfortNoise = 2 };

[ossu, 2017/02/01 15:05:26]

I think these should be left as-is, i.e. one-per-line.

[kwiberg-webrtc, 2017/02/01 20:15:02]

Since I moved this file, "git cl format" considered every line changed and fair
game for reformatting, and I've long since come to the conclusion that fighting
git cl format simply isn't worth it.

Do you feel strongly about this particular case?

[ossu, 2017/02/06 12:54:16]

Yeah, I figured that might've been the case.
I've not yet reached that same conclusion. clang-format is a great tool, but I
don't think it should be the ultimate decider on what's more readable. In this
case, you haven't actually changed this enum, so it's especially unnecessary to
change its formatting.

[kwiberg-webrtc, 2017/02/06 14:19:36]

Fair enough. If a human really cares, that human should get to decide...

[ossu, 2017/02/06 14:44:06]

Thanks! :)

[kwiberg-webrtc, 2017/02/09 20:08:30]

Aha! If I add a trailing comma just before the closing brace, clang-format
thinks it should be on separate lines, but without the trailing comma, it wants
it all on one line. Makes some sort of sense. I'll add the trailing comma.

 
   // Used by PacketDuration below. Save the value -1 for errors.
   enum { kNotImplemented = -2 };
 
   AudioDecoder() = default;
   virtual ~AudioDecoder() = default;
 
   class EncodedAudioFrame {
    public:
     struct DecodeResult {
@@ skipping 30 matching lines @@
     // The timestamp of the frame is in samples per channel.
     uint32_t timestamp;
     // The relative priority of the frame compared to other frames of the same
     // payload and the same timeframe. A higher value means a lower priority.
     // The highest priority is zero - negative values are not allowed.
     int priority;
     std::unique_ptr<EncodedAudioFrame> frame;
   };
 
   // Let the decoder parse this payload and prepare zero or more decodable
   // frames. Each frame must be between 10 ms and 120 ms long. The caller must

[the sun, 2017/02/02 21:02:29]

nit: it must be from 10 ms up to 120 ms long? can you create a separate issue to
go through the docs of this class? In fact, make it an issue about tidying up
this interface, if there isn't one already.

[kwiberg-webrtc, 2017/02/03 09:50:11]

Yes, I believe that's what NetEq et al. expect.
I'll see if I can sit down with Oskar on Monday and enumerate all the problems
we can think of in a bug.

[ossu, 2017/02/06 12:54:16]

Wait, what?

[kwiberg-webrtc, 2017/02/06 14:19:36]

I think we've probably already talked about most of this stuff in some detail at
least twice, so it'd probably save time if we just sat down and documented
what's still wrong with it. The worst warts are already gone, I think, but there
are some left.

[ossu, 2017/02/06 14:44:06]

Oh, right, yes, I agree. I was thinking this was referring to the new
EncodedAudioFrame interface, for some reason - context is sometimes difficult in
rietveld. AudioDecoder definitely needs tidying up. Let's have a proper
in-person meeting once I get back. Perhaps schedule something tentatively for
thursday?

   // ensure that the AudioDecoder object outlives any frame objects returned by
   // this call. The decoder is free to swap or move the data from the |payload|
   // buffer. |timestamp| is the input timestamp, in samples, corresponding to
   // the start of the payload.
   virtual std::vector<ParseResult> ParsePayload(rtc::Buffer&& payload,
                                                 uint32_t timestamp);
 
   // Decodes |encode_len| bytes from |encoded| and writes the result in
   // |decoded|. The maximum bytes allowed to be written into |decoded| is
   // |max_decoded_bytes|. Returns the total number of samples across all
@@ skipping 75 matching lines @@
                                       size_t encoded_len,
                                       int sample_rate_hz,
                                       int16_t* decoded,
                                       SpeechType* speech_type);
 
  private:
   RTC_DISALLOW_COPY_AND_ASSIGN(AudioDecoder);
 };
 
 }  // namespace webrtc
-#endif  // WEBRTC_MODULES_AUDIO_CODING_CODECS_AUDIO_DECODER_H_
+#endif  // WEBRTC_API_AUDIO_CODEC_AUDIO_DECODER_H_