Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2666853002: Move DTMF sender to RtpSender (as opposed to WebRtcSession). (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move DTMF sender to RtpSender (as opposed to WebRtcSession). Previously in the spec, there was a createDtmfSender method on PeerConnection, but that's been replaced by a "dtmf" attribute on RtpSender, which allows getting a DTMF sender without having an audio track. This also simplifies the code slightly, since tracks are now not necessary for identification. BUG=webrtc:4180 Review-Url: https://codereview.webrtc.org/2666853002 Cr-Commit-Position: refs/heads/master@{#16409} Committed: https://chromium.googlesource.com/external/webrtc/+/20cb0c1c85d4571919106019a562bbcbd35041fd

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding rewritten versions of removed webrtcsession tests #

Patch Set 3 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -191 lines) Patch
M webrtc/api/rtpsenderinterface.h View 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/api/test/mock_rtpsender.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/dtmfsender.h View 2 chunks +7 lines, -6 lines 0 comments Download
M webrtc/pc/dtmfsender.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M webrtc/pc/dtmfsender_unittest.cc View 5 chunks +7 lines, -16 lines 0 comments Download
M webrtc/pc/peerconnection.cc View 1 2 1 chunk +6 lines, -11 lines 0 comments Download
M webrtc/pc/rtpsender.h View 6 chunks +19 lines, -3 lines 0 comments Download
M webrtc/pc/rtpsender.cc View 6 chunks +64 lines, -1 line 0 comments Download
M webrtc/pc/rtpsenderreceiver_unittest.cc View 1 8 chunks +85 lines, -2 lines 0 comments Download
M webrtc/pc/webrtcsession.h View 4 chunks +0 lines, -11 lines 0 comments Download
M webrtc/pc/webrtcsession.cc View 1 2 3 chunks +0 lines, -67 lines 0 comments Download
M webrtc/pc/webrtcsession_unittest.cc View 7 chunks +0 lines, -69 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Taylor Brandstetter
https://codereview.webrtc.org/2666853002/diff/1/webrtc/pc/webrtcsession_unittest.cc File webrtc/pc/webrtcsession_unittest.cc (left): https://codereview.webrtc.org/2666853002/diff/1/webrtc/pc/webrtcsession_unittest.cc#oldcode3541 webrtc/pc/webrtcsession_unittest.cc:3541: } Moved to RtpSender tests.
3 years, 10 months ago (2017-02-01 22:10:00 UTC) #1
pthatcher1
lgtm
3 years, 10 months ago (2017-02-02 01:33:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2666853002/40001
3 years, 10 months ago (2017-02-02 03:26:44 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 04:27:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/20cb0c1c85d4571919106019a...

Powered by Google App Engine
This is Rietveld 408576698