Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: webrtc/pc/webrtcsession.h

Issue 2666853002: Move DTMF sender to RtpSender (as opposed to WebRtcSession). (Closed)
Patch Set: Merge with master Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/rtpsenderreceiver_unittest.cc ('k') | webrtc/pc/webrtcsession.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/webrtcsession.h
diff --git a/webrtc/pc/webrtcsession.h b/webrtc/pc/webrtcsession.h
index c25083330790aefff702cb2db5544584a5250b65..f8e0830ad00bfe7805dc142c9e4da20c0ca2f068 100644
--- a/webrtc/pc/webrtcsession.h
+++ b/webrtc/pc/webrtcsession.h
@@ -27,7 +27,6 @@
#include "webrtc/p2p/base/candidate.h"
#include "webrtc/p2p/base/transportcontroller.h"
#include "webrtc/pc/datachannel.h"
-#include "webrtc/pc/dtmfsender.h"
#include "webrtc/pc/mediacontroller.h"
#include "webrtc/pc/mediasession.h"
@@ -140,8 +139,6 @@ struct ChannelNamePairs {
// packets are represented by TransportChannels. The application-level protocol
// is represented by SessionDecription objects.
class WebRtcSession :
-
- public DtmfProviderInterface,
public DataChannelProviderInterface,
public sigslot::has_slots<> {
public:
@@ -285,12 +282,6 @@ class WebRtcSession :
virtual bool GetLocalTrackIdBySsrc(uint32_t ssrc, std::string* track_id);
virtual bool GetRemoteTrackIdBySsrc(uint32_t ssrc, std::string* track_id);
- // Implements DtmfProviderInterface.
- bool CanInsertDtmf(const std::string& track_id) override;
- bool InsertDtmf(const std::string& track_id,
- int code, int duration) override;
- sigslot::signal0<>* GetOnDestroyedSignal() override;
-
// Implements DataChannelProviderInterface.
bool SendData(const cricket::SendDataParams& params,
const rtc::CopyOnWriteBuffer& payload,
@@ -361,8 +352,6 @@ class WebRtcSession :
sigslot::signal0<> SignalVideoChannelDestroyed;
sigslot::signal0<> SignalDataChannelCreated;
sigslot::signal0<> SignalDataChannelDestroyed;
- // Called when the whole session is destroyed.
- sigslot::signal0<> SignalDestroyed;
// Called when a valid data channel OPEN message is received.
// std::string represents the data channel label.
« no previous file with comments | « webrtc/pc/rtpsenderreceiver_unittest.cc ('k') | webrtc/pc/webrtcsession.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698