Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: webrtc/pc/dtmfsender.h

Issue 2666853002: Move DTMF sender to RtpSender (as opposed to WebRtcSession). (Closed)
Patch Set: Merge with master Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/test/mock_rtpsender.h ('k') | webrtc/pc/dtmfsender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/dtmfsender.h
diff --git a/webrtc/pc/dtmfsender.h b/webrtc/pc/dtmfsender.h
index a019e788e4090b6040c87babbac08e51965ad52a..5eab0551854ce475d638b867821bbd5b066b7805 100644
--- a/webrtc/pc/dtmfsender.h
+++ b/webrtc/pc/dtmfsender.h
@@ -34,14 +34,13 @@ namespace webrtc {
// to send DTMF.
class DtmfProviderInterface {
public:
- // Returns true if the audio track with given id (|track_id|) is capable
- // of sending DTMF. Otherwise returns false.
- virtual bool CanInsertDtmf(const std::string& track_id) = 0;
- // Sends DTMF |code| via the audio track with given id (|track_id|).
+ // Returns true if the audio sender is capable of sending DTMF. Otherwise
+ // returns false.
+ virtual bool CanInsertDtmf() = 0;
+ // Sends DTMF |code|.
// The |duration| indicates the length of the DTMF tone in ms.
// Returns true on success and false on failure.
- virtual bool InsertDtmf(const std::string& track_id,
- int code, int duration) = 0;
+ virtual bool InsertDtmf(int code, int duration) = 0;
// Returns a |sigslot::signal0<>| signal. The signal should fire before
// the provider is destroyed.
virtual sigslot::signal0<>* GetOnDestroyedSignal() = 0;
@@ -55,6 +54,8 @@ class DtmfSender
public sigslot::has_slots<>,
public rtc::MessageHandler {
public:
+ // |track| is only there for backwards compatibility, since there's a track
+ // accessor method.
static rtc::scoped_refptr<DtmfSender> Create(
AudioTrackInterface* track,
rtc::Thread* signaling_thread,
« no previous file with comments | « webrtc/api/test/mock_rtpsender.h ('k') | webrtc/pc/dtmfsender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698