Add override declarations to PeerConnectionObserver subclasses, and delete obsolete methods.

Add override declarations to PeerConnectionObserver subclasses, and delete obsolete methods.

BUG=None

Review-Url: https://codereview.webrtc.org/2660223002
Cr-Commit-Position: refs/heads/master@{#16374}
Committed: https://chromium.googlesource.com/external/webrtc/+/63b14b7d15d9481f81424fc61bd8e90fc9bafaee

[nisse-webrtc, 2017-01-30 16:27:57]

nisse@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, magjed@webrtc.org

[nisse-webrtc, 2017-01-30 16:27:58]

PTAL.

The "obsolete methods" are OnIceComplete and OnStateChange. Which as far as I
can tell are no longer in the interface, and never called. I don't know when
they disappeared, but the TODO item on OnStateChange in
peerconnectioninterface_unittest.cc dates from beginning of git history in 2013.

[Taylor Brandstetter, 2017-01-30 16:41:30]

lgtm

[nisse-webrtc, 2017-01-31 09:12:01]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 09:12:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-01-31 09:19:40]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org

[nisse-webrtc, 2017-01-31 09:19:41]

Per, OWNER's approval needed for examples. And magjed is on vacation.

[commit-bot: I haz the power, 2017-01-31 10:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 10:15:11]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2017-01-31 11:03:32]

lgtm

[nisse-webrtc, 2017-01-31 11:31:33]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-01-31 11:31:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-31 11:34:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485862293967270, "parent_rev":
"1783f169d97794e1a0d50ec5af8fa586aa41f206", "commit_rev":
"63b14b7d15d9481f81424fc61bd8e90fc9bafaee"}

[commit-bot: I haz the power, 2017-01-31 11:34:04]

Description was changed from

==========
Add override declarations to PeerConnectionObserver subclasses, and delete
obsolete methods.

BUG=None
==========

to

==========
Add override declarations to PeerConnectionObserver subclasses, and delete
obsolete methods.

BUG=None

Review-Url: https://codereview.webrtc.org/2660223002
Cr-Commit-Position: refs/heads/master@{#16374}
Committed:
https://chromium.googlesource.com/external/webrtc/+/63b14b7d15d9481f81424fc61...
==========

[commit-bot: I haz the power, 2017-01-31 11:34:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/63b14b7d15d9481f81424fc61...