Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: webrtc/pc/peerconnectionfactory_unittest.cc

Issue 2660223002: Add override declarations to PeerConnectionObserver subclasses, and delete obsolete methods. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/examples/peerconnection/client/conductor.h ('k') | webrtc/pc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/peerconnectionfactory_unittest.cc
diff --git a/webrtc/pc/peerconnectionfactory_unittest.cc b/webrtc/pc/peerconnectionfactory_unittest.cc
index a1789986227cd5cc8f0ee48c41fcd96c8140f286..3fa523e3e710b22932c6c928cb77e5ce2487ac9a 100644
--- a/webrtc/pc/peerconnectionfactory_unittest.cc
+++ b/webrtc/pc/peerconnectionfactory_unittest.cc
@@ -71,21 +71,20 @@ class NullPeerConnectionObserver : public PeerConnectionObserver {
using PeerConnectionObserver::OnDataChannel;
virtual ~NullPeerConnectionObserver() = default;
- virtual void OnMessage(const std::string& msg) {}
- virtual void OnSignalingMessage(const std::string& msg) {}
- virtual void OnSignalingChange(
- PeerConnectionInterface::SignalingState new_state) {}
- virtual void OnAddStream(rtc::scoped_refptr<MediaStreamInterface> stream) {}
- virtual void OnRemoveStream(rtc::scoped_refptr<MediaStreamInterface> stream) {
- }
- virtual void OnDataChannel(
- rtc::scoped_refptr<DataChannelInterface> data_channel) {}
- virtual void OnRenegotiationNeeded() {}
- virtual void OnIceConnectionChange(
- PeerConnectionInterface::IceConnectionState new_state) {}
- virtual void OnIceGatheringChange(
- PeerConnectionInterface::IceGatheringState new_state) {}
- virtual void OnIceCandidate(const webrtc::IceCandidateInterface* candidate) {}
+ void OnSignalingChange(
+ PeerConnectionInterface::SignalingState new_state) override {}
+ void OnAddStream(rtc::scoped_refptr<MediaStreamInterface> stream) override {}
+ void OnRemoveStream(
+ rtc::scoped_refptr<MediaStreamInterface> stream) override {}
+ void OnDataChannel(
+ rtc::scoped_refptr<DataChannelInterface> data_channel) override {}
+ void OnRenegotiationNeeded() override {}
+ void OnIceConnectionChange(
+ PeerConnectionInterface::IceConnectionState new_state) override {}
+ void OnIceGatheringChange(
+ PeerConnectionInterface::IceGatheringState new_state) override {}
+ void OnIceCandidate(
+ const webrtc::IceCandidateInterface* candidate) override {}
};
} // namespace
« no previous file with comments | « webrtc/examples/peerconnection/client/conductor.h ('k') | webrtc/pc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698