Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: webrtc/pc/test/peerconnectiontestwrapper.h

Issue 2660223002: Add override declarations to PeerConnectionObserver subclasses, and delete obsolete methods. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/peerconnectioninterface_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/test/peerconnectiontestwrapper.h
diff --git a/webrtc/pc/test/peerconnectiontestwrapper.h b/webrtc/pc/test/peerconnectiontestwrapper.h
index 59e6968f14fe7977fd0f9301e793c67904308093..b761b05fcd0b9361409b8176d17debfb8793b95e 100644
--- a/webrtc/pc/test/peerconnectiontestwrapper.h
+++ b/webrtc/pc/test/peerconnectiontestwrapper.h
@@ -50,27 +50,24 @@ class PeerConnectionTestWrapper
const webrtc::DataChannelInit& init);
// Implements PeerConnectionObserver.
- virtual void OnSignalingChange(
- webrtc::PeerConnectionInterface::SignalingState new_state) {}
- virtual void OnStateChange(
- webrtc::PeerConnectionObserver::StateType state_changed) {}
- virtual void OnAddStream(
- rtc::scoped_refptr<webrtc::MediaStreamInterface> stream);
- virtual void OnRemoveStream(
- rtc::scoped_refptr<webrtc::MediaStreamInterface> stream) {}
- virtual void OnDataChannel(
- rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel);
- virtual void OnRenegotiationNeeded() {}
- virtual void OnIceConnectionChange(
- webrtc::PeerConnectionInterface::IceConnectionState new_state) {}
- virtual void OnIceGatheringChange(
- webrtc::PeerConnectionInterface::IceGatheringState new_state) {}
- virtual void OnIceCandidate(const webrtc::IceCandidateInterface* candidate);
- virtual void OnIceComplete() {}
+ void OnSignalingChange(
+ webrtc::PeerConnectionInterface::SignalingState new_state) override {}
+ void OnAddStream(
+ rtc::scoped_refptr<webrtc::MediaStreamInterface> stream) override;
+ void OnRemoveStream(
+ rtc::scoped_refptr<webrtc::MediaStreamInterface> stream) override {}
+ void OnDataChannel(
+ rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel) override ;
+ void OnRenegotiationNeeded() override {}
+ void OnIceConnectionChange(
+ webrtc::PeerConnectionInterface::IceConnectionState new_state) override {}
+ void OnIceGatheringChange(
+ webrtc::PeerConnectionInterface::IceGatheringState new_state) override {}
+ void OnIceCandidate(const webrtc::IceCandidateInterface* candidate) override;
// Implements CreateSessionDescriptionObserver.
- virtual void OnSuccess(webrtc::SessionDescriptionInterface* desc);
- virtual void OnFailure(const std::string& error) {}
+ void OnSuccess(webrtc::SessionDescriptionInterface* desc) override;
+ void OnFailure(const std::string& error) override {}
void CreateOffer(const webrtc::MediaConstraintsInterface* constraints);
void CreateAnswer(const webrtc::MediaConstraintsInterface* constraints);
« no previous file with comments | « webrtc/pc/peerconnectioninterface_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698