Reland of GN: Refactor modules_unittests to eliminate package boundary violations.

Reland of GN: Refactor modules_unittests to eliminate package boundary violations. (patchset #1 id:1 of https://codereview.webrtc.org/2651023005/ )

Reason for revert:
Will change the name from bwe_simulator to bwe_simulator_test.

Original issue's description:
> Revert of GN: Refactor modules_unittests to eliminate package boundary violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/ )
> 
> Reason for revert:
> Did break the bots.
> https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807
> 
> Original issue's description:
> > GN: Refactor modules_unittests to eliminate package boundary violations.
> > 
> > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator
> > 
> > BUG=webrtc:6954
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2649563002
> > Cr-Commit-Position: refs/heads/master@{#16270}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e1fb75cae1a940a6
> 
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6954
> 
> Review-Url: https://codereview.webrtc.org/2651023005
> Cr-Commit-Position: refs/heads/master@{#16271}
> Committed: https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e9998cd225dd6be477c

R=kjellander@webrtc.org
NOTRY=true
BUG=webrtc:6954
Review-Url: https://codereview.webrtc.org/2653173003
Cr-Commit-Position: refs/heads/master@{#16356}
Committed: https://chromium.googlesource.com/external/webrtc/+/9cbb0a16e5a02538dc9cb18ec9d447e2d2058ec3

[ehmaldonado_webrtc, 2017-01-25 16:12:42]

Created Reland of GN: Refactor modules_unittests to eliminate package boundary
violations.

[ehmaldonado_webrtc, 2017-01-25 16:15:32]

Description was changed from

==========
Reland of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #1 id:1 of https://codereview.webrtc.org/2651023005/ )

Reason for revert:
Will change the name from bwe_simulator to bwe_simulator_test.

Original issue's description:
> Revert of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/
)
> 
> Reason for revert:
> Did break the bots.
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807
> 
> Original issue's description:
> > GN: Refactor modules_unittests to eliminate package boundary violations.
> > 
> > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator
> > 
> > BUG=webrtc:6954
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2649563002
> > Cr-Commit-Position: refs/heads/master@{#16270}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e...
> 
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6954
> 
> Review-Url: https://codereview.webrtc.org/2651023005
> Cr-Commit-Position: refs/heads/master@{#16271}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e999...

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6954
==========

to

==========
Reland of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #1 id:1 of https://codereview.webrtc.org/2651023005/ )

Reason for revert:
Will change the name from bwe_simulator to bwe_simulator_test.

Original issue's description:
> Revert of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/
)
> 
> Reason for revert:
> Did break the bots.
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807
> 
> Original issue's description:
> > GN: Refactor modules_unittests to eliminate package boundary violations.
> > 
> > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator
> > 
> > BUG=webrtc:6954
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2649563002
> > Cr-Commit-Position: refs/heads/master@{#16270}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e...
> 
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6954
> 
> Review-Url: https://codereview.webrtc.org/2651023005
> Cr-Commit-Position: refs/heads/master@{#16271}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e999...

R=kjellander@webrtc.org
NOTRY=true
BUG=webrtc:6954
==========

[ehmaldonado_webrtc, 2017-01-25 16:30:04]

So it failed on the bots. Should I rename it?

[ehmaldonado_webrtc, 2017-01-25 16:42:34]

ehmaldonado@webrtc.org changed reviewers:
+ stefan@webrtc.org

[kjellander_webrtc, 2017-01-25 16:42:47]

On 2017/01/25 16:30:04, ehmaldonado_webrtc wrote:
> So it failed on the bots. Should I rename it?

Yes, lgtm

I hate not understanding why, but since we're unable to repro even on the bots,
I don't see any point spending more time investigating this.

[ehmaldonado_webrtc, 2017-01-25 16:43:37]

+stefan
This is moving bwe_simulator from modules/BUILD.gn to
modules/remote_bitrate_estimator/BUILD.gn and renaming it to bwe_simulator_test.
For some reason it doesn't compile on the bots on iOS32

[stefan-webrtc, 2017-01-26 14:39:27]

https://codereview.webrtc.org/2653173003/diff/160001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2653173003/diff/160001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/BUILD.gn:1142:
rtc_source_set("audio_coding_modules_tests") {
What's the difference between this and audio_coding_tests above? They are named
very similarly.

https://codereview.webrtc.org/2653173003/diff/160001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/BUILD.gn (right):

https://codereview.webrtc.org/2653173003/diff/160001/webrtc/modules/video_cod...
webrtc/modules/video_coding/BUILD.gn:314:
rtc_source_set("video_coding_modules_tests") {
video_coding_tests? More similar to video_coding_tests below

[ehmaldonado_webrtc, 2017-01-26 15:24:06]

audio_coding_MODULES_tests are part of the target
"//webrtc/modules:modules_tests"
audio_coding_tests are part of the target "//webrtc:webrtc_tests"

I'm not sure why there are two different targets with different tests on them,
this just splits modules_tests into different targets.

[kjellander_webrtc, 2017-01-26 15:45:52]

On 2017/01/26 15:24:06, ehmaldonado_webrtc wrote:
> audio_coding_MODULES_tests are part of the target
> "//webrtc/modules:modules_tests"
> audio_coding_tests are part of the target "//webrtc:webrtc_tests"

Right, this is just a group target that ensures all targets are built when we
compile the //:default target at the top-level. I agree it's confusing that it
has _tests in the name, but it is a collection of test targets. The target type
should make it obvious that it is in fact not a test (but I'm all fine for
renaming it)

> I'm not sure why there are two different targets with different tests on them,
> this just splits modules_tests into different targets.

Yes, this just moves files to make the source listings more localized, to avoid
crossing package boundaries (which is needed to generate Bazel BUILD files).

[ehmaldonado_webrtc, 2017-01-27 09:03:54]

stefan, do you mind renaming bwe_simulator to bwe_simulator_test?

[stefan-webrtc, 2017-01-30 10:47:23]

lgtm

I would have picked video_coding_tests as a name instead of
video_coding_modules_tests, but perhaps I don't understand the full picture. No
big deal anyway.

[ehmaldonado_webrtc, 2017-01-30 11:04:19]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-01-30 11:04:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2653173003/#ps180001 (title:
"Rename bwe_simulator_test -> bwe_simulations_tests.")

[commit-bot: I haz the power, 2017-01-30 11:04:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-30 11:07:03]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1485774259279540,
"parent_rev": "26d79eead004e1b25c82e9984179aae266d39650", "commit_rev":
"9cbb0a16e5a02538dc9cb18ec9d447e2d2058ec3"}

[commit-bot: I haz the power, 2017-01-30 11:07:06]

Description was changed from

==========
Reland of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #1 id:1 of https://codereview.webrtc.org/2651023005/ )

Reason for revert:
Will change the name from bwe_simulator to bwe_simulator_test.

Original issue's description:
> Revert of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/
)
> 
> Reason for revert:
> Did break the bots.
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807
> 
> Original issue's description:
> > GN: Refactor modules_unittests to eliminate package boundary violations.
> > 
> > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator
> > 
> > BUG=webrtc:6954
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2649563002
> > Cr-Commit-Position: refs/heads/master@{#16270}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e...
> 
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6954
> 
> Review-Url: https://codereview.webrtc.org/2651023005
> Cr-Commit-Position: refs/heads/master@{#16271}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e999...

R=kjellander@webrtc.org
NOTRY=true
BUG=webrtc:6954
==========

to

==========
Reland of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #1 id:1 of https://codereview.webrtc.org/2651023005/ )

Reason for revert:
Will change the name from bwe_simulator to bwe_simulator_test.

Original issue's description:
> Revert of GN: Refactor modules_unittests to eliminate package boundary
violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/
)
> 
> Reason for revert:
> Did break the bots.
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807
> 
> Original issue's description:
> > GN: Refactor modules_unittests to eliminate package boundary violations.
> > 
> > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator
> > 
> > BUG=webrtc:6954
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2649563002
> > Cr-Commit-Position: refs/heads/master@{#16270}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e...
> 
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6954
> 
> Review-Url: https://codereview.webrtc.org/2651023005
> Cr-Commit-Position: refs/heads/master@{#16271}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e999...

R=kjellander@webrtc.org
NOTRY=true
BUG=webrtc:6954

Review-Url: https://codereview.webrtc.org/2653173003
Cr-Commit-Position: refs/heads/master@{#16356}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9cbb0a16e5a02538dc9cb18ec...
==========

[commit-bot: I haz the power, 2017-01-30 11:07:08]

Committed patchset #3 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/9cbb0a16e5a02538dc9cb18ec...