GN: Refactor modules_unittests to eliminate package boundary violations.

GN: Refactor modules_unittests to eliminate package boundary violations.

Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator

BUG=webrtc:6954
NOTRY=True

Review-Url: https://codereview.webrtc.org/2649563002
Cr-Commit-Position: refs/heads/master@{#16270}
Committed: https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e1fb75cae1a940a6

[ehmaldonado_webrtc, 2017-01-23 11:21:06]

Patchset #2 (id:20001) has been deleted

[ehmaldonado_webrtc, 2017-01-23 14:15:24]

Patchset #3 (id:60001) has been deleted

[ehmaldonado_webrtc, 2017-01-24 11:04:11]

Patchset #3 (id:70001) has been deleted

[ehmaldonado_webrtc, 2017-01-24 15:28:50]

Patchset #4 (id:110001) has been deleted

[ehmaldonado_webrtc, 2017-01-24 15:29:59]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2017-01-24 15:30:00]

Can you review please?
I haven't figured out why it doesn't work if it's named "bwe_simulator"...

[kjellander_webrtc, 2017-01-25 07:03:35]

On 2017/01/24 15:30:00, ehmaldonado_webrtc wrote:
> Can you review please?
> I haven't figured out why it doesn't work if it's named "bwe_simulator"...

I'm unable to reproduce the error for PS#2 on my Mac, it builds just fine.
Can you ssh into the golo machine after a failed tryjob and have a look at the
file system locally? I'd like to understand what's going on before renaming the
target (since it'll confuse its users).

[ehmaldonado_webrtc, 2017-01-25 14:13:44]

On 2017/01/25 07:03:35, kjellander_webrtc wrote:
> On 2017/01/24 15:30:00, ehmaldonado_webrtc wrote:
> > Can you review please?
> > I haven't figured out why it doesn't work if it's named "bwe_simulator"...
> 
> I'm unable to reproduce the error for PS#2 on my Mac, it builds just fine.
> Can you ssh into the golo machine after a failed tryjob and have a look at the
> file system locally? I'd like to understand what's going on before renaming
the
> target (since it'll confuse its users).

I ssh'd into the trybot and I couldn't repro it there either. It compiles just
fine.

[ehmaldonado_webrtc, 2017-01-25 14:16:48]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 14:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 14:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:27:09]

Dry run: Try jobs failed on following builders:
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/20811)

[kjellander_webrtc, 2017-01-25 15:37:37]

On 2017/01/25 14:13:44, ehmaldonado_webrtc wrote:
> On 2017/01/25 07:03:35, kjellander_webrtc wrote:
> > On 2017/01/24 15:30:00, ehmaldonado_webrtc wrote:
> > > Can you review please?
> > > I haven't figured out why it doesn't work if it's named "bwe_simulator"...
> > 
> > I'm unable to reproduce the error for PS#2 on my Mac, it builds just fine.
> > Can you ssh into the golo machine after a failed tryjob and have a look at
the
> > file system locally? I'd like to understand what's going on before renaming
> the
> > target (since it'll confuse its users).
> 
> I ssh'd into the trybot and I couldn't repro it there either. It compiles just
> fine.

That's very odd. I suggest we just commit and see what the commit-bots say. I
suspect they will pass just fine (otherwise we'll just revert).

[ehmaldonado_webrtc, 2017-01-25 15:38:58]

Description was changed from

==========
GN: Refactor modules_unittests to eliminate package boundary violations.

Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator

BUG=webrtc:6954
==========

to

==========
GN: Refactor modules_unittests to eliminate package boundary violations.

Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator

BUG=webrtc:6954
NOTRY=True
==========

[ehmaldonado_webrtc, 2017-01-25 15:39:35]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-01-25 15:39:38]

The CQ bit was unchecked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-01-25 15:40:00]

On 2017/01/25 15:37:37, kjellander_webrtc wrote:
> On 2017/01/25 14:13:44, ehmaldonado_webrtc wrote:
> > On 2017/01/25 07:03:35, kjellander_webrtc wrote:
> > > On 2017/01/24 15:30:00, ehmaldonado_webrtc wrote:
> > > > Can you review please?
> > > > I haven't figured out why it doesn't work if it's named
"bwe_simulator"...
> > > 
> > > I'm unable to reproduce the error for PS#2 on my Mac, it builds just fine.
> > > Can you ssh into the golo machine after a failed tryjob and have a look at
> the
> > > file system locally? I'd like to understand what's going on before
renaming
> > the
> > > target (since it'll confuse its users).
> > 
> > I ssh'd into the trybot and I couldn't repro it there either. It compiles
just
> > fine.
> 
> That's very odd. I suggest we just commit and see what the commit-bots say. I
> suspect they will pass just fine (otherwise we'll just revert).

LGTM, then?

[kjellander_webrtc, 2017-01-25 15:49:34]

On 2017/01/25 15:40:00, ehmaldonado_webrtc wrote:
> On 2017/01/25 15:37:37, kjellander_webrtc wrote:
> > On 2017/01/25 14:13:44, ehmaldonado_webrtc wrote:
> > > On 2017/01/25 07:03:35, kjellander_webrtc wrote:
> > > > On 2017/01/24 15:30:00, ehmaldonado_webrtc wrote:
> > > > > Can you review please?
> > > > > I haven't figured out why it doesn't work if it's named
> "bwe_simulator"...
> > > > 
> > > > I'm unable to reproduce the error for PS#2 on my Mac, it builds just
fine.
> > > > Can you ssh into the golo machine after a failed tryjob and have a look
at
> > the
> > > > file system locally? I'd like to understand what's going on before
> renaming
> > > the
> > > > target (since it'll confuse its users).
> > > 
> > > I ssh'd into the trybot and I couldn't repro it there either. It compiles
> just
> > > fine.
> > 
> > That's very odd. I suggest we just commit and see what the commit-bots say.
I
> > suspect they will pass just fine (otherwise we'll just revert).
> 
> LGTM, then?

Whops, yes; lgtm

[ehmaldonado_webrtc, 2017-01-25 15:57:35]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-01-25 15:57:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-25 16:00:15]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1485359855173920,
"parent_rev": "26764613ad49e4b68fadc4d725ed7c6fdb609656", "commit_rev":
"36cb55d7157dcba872f666e0e1fb75cae1a940a6"}

[commit-bot: I haz the power, 2017-01-25 16:00:19]

Description was changed from

==========
GN: Refactor modules_unittests to eliminate package boundary violations.

Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator

BUG=webrtc:6954
NOTRY=True
==========

to

==========
GN: Refactor modules_unittests to eliminate package boundary violations.

Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator

BUG=webrtc:6954
NOTRY=True

Review-Url: https://codereview.webrtc.org/2649563002
Cr-Commit-Position: refs/heads/master@{#16270}
Committed:
https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e...
==========

[commit-bot: I haz the power, 2017-01-25 16:00:20]

Committed patchset #4 (id:130001) as
https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e...

[ehmaldonado_webrtc, 2017-01-25 16:11:11]

A revert of this CL (patchset #4 id:130001) has been created in
https://codereview.webrtc.org/2651023005/ by ehmaldonado@webrtc.org.

The reason for reverting is: Did break the bots.
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807.

[kjellander_webrtc, 2017-01-25 16:39:10]

On 2017/01/25 16:11:11, ehmaldonado_webrtc wrote:
> A revert of this CL (patchset #4 id:130001) has been created in
> https://codereview.webrtc.org/2651023005/ by mailto:ehmaldonado@webrtc.org.
> 
> The reason for reverting is: Did break the bots.
>
https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807.

*sigh* OK let's just rename it then. Let Stefan know about it for the reland CL.