Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2651023005: Revert of GN: Refactor modules_unittests to eliminate package boundary violations. (Closed)

Created:
3 years, 11 months ago by ehmaldonado_webrtc
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, kwiberg-webrtc, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN: Refactor modules_unittests to eliminate package boundary violations. (patchset #4 id:130001 of https://codereview.webrtc.org/2649563002/ ) Reason for revert: Did break the bots. https://build.chromium.org/p/client.webrtc/builders/iOS32%20Release/builds/9807 Original issue's description: > GN: Refactor modules_unittests to eliminate package boundary violations. > > Also move bwe_simulator to webrtc/modules/remote_bitrate_estimator > > BUG=webrtc:6954 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2649563002 > Cr-Commit-Position: refs/heads/master@{#16270} > Committed: https://chromium.googlesource.com/external/webrtc/+/36cb55d7157dcba872f666e0e1fb75cae1a940a6 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6954 Review-Url: https://codereview.webrtc.org/2651023005 Cr-Commit-Position: refs/heads/master@{#16271} Committed: https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e9998cd225dd6be477c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -147 lines) Patch
M webrtc/modules/BUILD.gn View 2 chunks +83 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ehmaldonado_webrtc
Created Revert of GN: Refactor modules_unittests to eliminate package boundary violations.
3 years, 11 months ago (2017-01-25 16:11:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2651023005/1
3 years, 11 months ago (2017-01-25 16:11:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3373eaa57757386823730e9998cd225dd6be477c
3 years, 11 months ago (2017-01-25 16:11:32 UTC) #6
ehmaldonado_webrtc
3 years, 11 months ago (2017-01-25 16:12:41 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2653173003/ by ehmaldonado@webrtc.org.

The reason for reverting is: Will change the name from bwe_simulator to
bwe_simulator_test..

Powered by Google App Engine
This is Rietveld 408576698