Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/base/BUILD.gn

Issue 2647663002: Delete or update left-over ASSERT use and comments. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/fileutils.h » ('j') | webrtc/base/fileutils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 51882da0f9b01facb2fd2ee0d7115bdf8d18bb09..16b010015d53de91c8d419e76c682786675c59f1 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -665,12 +665,6 @@ rtc_static_library("rtc_base") {
"unixfilesystem.cc",
"unixfilesystem.h",
]
- if (is_debug) {
- # The Chromium build/common.gypi defines this for all posix
- # _except_ for ios & mac. We want it there as well, e.g.
- # because ASSERT and friends trigger off of it.
- defines += [ "_DEBUG" ]
- }
kwiberg-webrtc 2017/01/23 12:25:14 Curiously, _DEBUG seems to be a Windows thing, not
nisse-webrtc 2017/01/23 12:53:03 I've search history, _DEBUG was used in lots of pl
}
if (is_nacl) {
« no previous file with comments | « no previous file | webrtc/base/fileutils.h » ('j') | webrtc/base/fileutils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698