Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1429513004: Switch usage of _DEBUG macro to NDEBUG. (Closed)

Created:
5 years, 1 month ago by tfarina
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, henrika_webrtc, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, the sun, mflodman, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Switch usage of _DEBUG macro to NDEBUG. http://stackoverflow.com/a/29253284/5237416 BUG=None R=tommi@webrtc.org NOPRESUBMIT=true Committed: https://crrev.com/a41ab9326c8f0f7eb738e5d51a239a2b9e276361 Cr-Commit-Position: refs/heads/master@{#10468}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -92 lines) Patch
M webrtc/base/diskcache.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/base/logging.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/logging.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/base/network.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/openssladapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/openssladapter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/base/opensslidentity.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/physicalsocketserver.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/base/sigslot.h View 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/base/stringutils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/task.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/base/taskparent.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/taskparent.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/taskrunner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/taskrunner.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/unittest_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/win32socketserver.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/libjingle/xmpp/xmppclient.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpplogintask.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpplogintask.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpptask.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpptask.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/fix/test/test_iSACfixfloat.c View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/system_wrappers/include/logging.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_defines.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 39 (19 generated)
tfarina
5 years, 1 month ago (2015-10-27 01:18:16 UTC) #1
Sergey Ulanov
+tommi as I'm owner of only some of these files.
5 years, 1 month ago (2015-10-27 17:34:33 UTC) #3
tfarina
Tommi, ping? Could you review this?
5 years, 1 month ago (2015-10-29 11:49:20 UTC) #4
tommi
lgtm
5 years, 1 month ago (2015-10-30 12:22:09 UTC) #6
tfarina
thanks
5 years, 1 month ago (2015-10-30 13:25:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/1
5 years, 1 month ago (2015-10-30 13:25:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/6577) android_gn_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 1 month ago (2015-10-30 13:31:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/20001
5 years, 1 month ago (2015-10-30 13:39:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1483)
5 years, 1 month ago (2015-10-30 13:44:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/20001
5 years, 1 month ago (2015-10-30 13:56:08 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/8729)
5 years, 1 month ago (2015-10-30 15:38:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/20001
5 years, 1 month ago (2015-10-30 15:39:43 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/8731)
5 years, 1 month ago (2015-10-30 16:14:41 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/20001
5 years, 1 month ago (2015-10-30 16:22:41 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/8686)
5 years, 1 month ago (2015-10-30 17:35:58 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/40001
5 years, 1 month ago (2015-10-30 19:04:55 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/8741)
5 years, 1 month ago (2015-10-30 20:59:55 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1429513004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1429513004/40001
5 years, 1 month ago (2015-10-30 22:16:20 UTC) #37
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-30 23:08:52 UTC) #38
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 23:09:04 UTC) #39
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a41ab9326c8f0f7eb738e5d51a239a2b9e276361
Cr-Commit-Position: refs/heads/master@{#10468}

Powered by Google App Engine
This is Rietveld 408576698