webrtc/system_wrappers/include/logging.h - Issue 1429513004: Switch usage of _DEBUG macro to NDEBUG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/include/logging.h

Issue 1429513004: Switch usage of _DEBUG macro to NDEBUG. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: REBASE Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/system_wrappers/include/logging.h

diff --git a/webrtc/system_wrappers/include/logging.h b/webrtc/system_wrappers/include/logging.h

index 41c436b1f3d0e50b0900e7d663331bde1477ee3d..d95c53e1760dd120a22f938506f7abfcd73ff901 100644

--- a/webrtc/system_wrappers/include/logging.h

+++ b/webrtc/system_wrappers/include/logging.h

@@ -131,7 +131,7 @@ class LogMessageVoidify {

webrtc::LogMessage(__FILE__, __LINE__, sev).stream()

// The _F version prefixes the message with the current function name.

-#if (defined(__GNUC__) && defined(_DEBUG)) || defined(WANT_PRETTY_LOG_F)

+#if (defined(__GNUC__) && !defined(NDEBUG)) || defined(WANT_PRETTY_LOG_F)

#define LOG_F(sev) LOG(sev) << __PRETTY_FUNCTION__ << ": "

#else

#define LOG_F(sev) LOG(sev) << __FUNCTION__ << ": "