Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1837393002: Re-enabling tests that were disabled for Windows debug builds. (Closed)

Created:
4 years, 8 months ago by Taylor Brandstetter
Modified:
4 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enabling tests that were disabled for Windows debug builds. The issue should be fixed by this commit: https://boringssl.googlesource.com/boringssl.git/+/feaa57d13daa0b5bf3c068ce18d24870d50bfae9 BUG=webrtc:5659 NOTRY=True R=kjellander@webrtc.org Committed: https://crrev.com/7ff1737e7c2b05f8e41c8b17de53169539aa89b5 Cr-Commit-Position: refs/heads/master@{#12200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -94 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 10 chunks +10 lines, -86 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Taylor Brandstetter
4 years, 8 months ago (2016-03-30 00:48:15 UTC) #2
kjellander_webrtc
Rolling chromium_revision in DEPS to get the BoringSSL update in is currently blocked due to ...
4 years, 8 months ago (2016-03-30 14:04:38 UTC) #3
kjellander_webrtc
On 2016/03/30 14:04:38, kjellander (webrtc) wrote: > Rolling chromium_revision in DEPS to get the BoringSSL ...
4 years, 8 months ago (2016-04-01 09:11:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837393002/1
4 years, 8 months ago (2016-04-01 18:41:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4559)
4 years, 8 months ago (2016-04-01 18:48:01 UTC) #9
Taylor Brandstetter
Committed patchset #1 (id:1) manually as 7ff1737e7c2b05f8e41c8b17de53169539aa89b5.
4 years, 8 months ago (2016-04-01 18:50:52 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:50:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ff1737e7c2b05f8e41c8b17de53169539aa89b5
Cr-Commit-Position: refs/heads/master@{#12200}

Powered by Google App Engine
This is Rietveld 408576698