Delete or update left-over ASSERT use and comments.

webrtc/base/fileutils.h

Index: webrtc/base/fileutils.h
diff --git a/webrtc/base/fileutils.h b/webrtc/base/fileutils.h
index 0c19ffc7f718fa347327832c08994db84dd01f7d..14d7091e475c5c83e6039060a74d6f96444a0161 100644
--- a/webrtc/base/fileutils.h
+++ b/webrtc/base/fileutils.h
@@ -92,12 +92,12 @@ class FilesystemInterface {
                                const std::string &mode) = 0;
 
   // This will attempt to delete the path located at filename.
-  // It ASSERTS and returns false if the path points to a folder or a
+  // It DCHECKs and returns false if the path points to a folder or a
   // non-existent file.

[kwiberg-webrtc, 2017/01/23 12:25:14]

Not your fault, but I'll just point out that this behavior conflicts with the
"don't handle DCHECK errors" rule.

[nisse-webrtc, 2017/01/23 12:53:03]

When I get to erplacing use of VERIFY, there's a common pattern to check if an
operation fails, and if so, trigger an abort in debug builds, but return some
failure value in non-debug builds.

See, e.g.,
https://cs.chromium.org/chromium/src/third_party/webrtc/pc/channel.cc?q=VERIF...

What do you suggest I do about those?

[kwiberg-webrtc, 2017/01/23 14:11:58]

I don't know. But I do know that DCHECK is the wrong thing to use for such
situations.

Personally, I lean towards not doing that at all, since the error handling path
is per construction difficult to test. But I realize this would make your
search-and-replace difficult...

Maybe post the first post in what's sure to be a centithread on e.g.
webrtc-eng@?

   virtual bool DeleteFile(const Pathname &filename) = 0;
 
   // This will attempt to delete the empty folder located at 'folder'
-  // It ASSERTS and returns false if the path points to a file or a non-existent
+  // It DCHECKs and returns false if the path points to a file or a non-existent
   // folder. It fails normally if the folder is not empty or can otherwise
   // not be deleted.
   virtual bool DeleteEmptyFolder(const Pathname &folder) = 0;
@@ -116,13 +116,13 @@ class FilesystemInterface {
   virtual bool CreateFolder(const Pathname &pathname) = 0;
 
   // This moves a file from old_path to new_path, where "old_path" is a
-  // plain file. This ASSERTs and returns false if old_path points to a
+  // plain file. This DCHECKs and returns false if old_path points to a
   // directory, and returns true if the function succeeds.
   // If the new path is on a different volume than the old path, this function
   // will attempt to copy and, if that succeeds, delete the old path.
   virtual bool MoveFile(const Pathname &old_path, const Pathname &new_path) = 0;
 
-  // This copies a file from old_path to new_path. This method ASSERTs and
+  // This copies a file from old_path to new_path. This method DCHECKs and
   // returns false if old_path is a folder, and returns true if the copy
   // succeeds.
   virtual bool CopyFile(const Pathname &old_path, const Pathname &new_path) = 0;