Delete or update left-over ASSERT use and comments.

webrtc/base/fileutils.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 74 matching lines @@
   virtual DirectoryIterator* IterateDirectory();
 
   // Opens a file. Returns an open StreamInterface if function succeeds.
   // Otherwise, returns NULL.
   // TODO: Add an error param to indicate failure reason, similar to
   // FileStream::Open
   virtual FileStream *OpenFile(const Pathname &filename,
                                const std::string &mode) = 0;
 
   // This will attempt to delete the path located at filename.
-  // It ASSERTS and returns false if the path points to a folder or a
+  // It DCHECKs and returns false if the path points to a folder or a
   // non-existent file.

[kwiberg-webrtc, 2017/01/23 12:25:14]

Not your fault, but I'll just point out that this behavior conflicts with the
"don't handle DCHECK errors" rule.

[nisse-webrtc, 2017/01/23 12:53:03]

When I get to erplacing use of VERIFY, there's a common pattern to check if an
operation fails, and if so, trigger an abort in debug builds, but return some
failure value in non-debug builds.

See, e.g.,
https://cs.chromium.org/chromium/src/third_party/webrtc/pc/channel.cc?q=VERIF...

What do you suggest I do about those?

[kwiberg-webrtc, 2017/01/23 14:11:58]

I don't know. But I do know that DCHECK is the wrong thing to use for such
situations.

Personally, I lean towards not doing that at all, since the error handling path
is per construction difficult to test. But I realize this would make your
search-and-replace difficult...

Maybe post the first post in what's sure to be a centithread on e.g.
webrtc-eng@?

   virtual bool DeleteFile(const Pathname &filename) = 0;
 
   // This will attempt to delete the empty folder located at 'folder'
-  // It ASSERTS and returns false if the path points to a file or a non-existent
+  // It DCHECKs and returns false if the path points to a file or a non-existent
   // folder. It fails normally if the folder is not empty or can otherwise
   // not be deleted.
   virtual bool DeleteEmptyFolder(const Pathname &folder) = 0;
 
   // This will call IterateDirectory, to get a directory iterator, and then
   // call DeleteFolderAndContents and DeleteFile on every path contained in this
   // folder. If the folder is empty, this returns true.
   virtual bool DeleteFolderContents(const Pathname &folder);
 
   // This deletes the contents of a folder, recursively, and then deletes
   // the folder itself.
   virtual bool DeleteFolderAndContents(const Pathname& folder);
 
   // Creates a directory. This will call itself recursively to create /foo/bar
   // even if /foo does not exist. Returns true if the function succeeds.
   virtual bool CreateFolder(const Pathname &pathname) = 0;
 
   // This moves a file from old_path to new_path, where "old_path" is a
-  // plain file. This ASSERTs and returns false if old_path points to a
+  // plain file. This DCHECKs and returns false if old_path points to a
   // directory, and returns true if the function succeeds.
   // If the new path is on a different volume than the old path, this function
   // will attempt to copy and, if that succeeds, delete the old path.
   virtual bool MoveFile(const Pathname &old_path, const Pathname &new_path) = 0;
 
-  // This copies a file from old_path to new_path. This method ASSERTs and
+  // This copies a file from old_path to new_path. This method DCHECKs and
   // returns false if old_path is a folder, and returns true if the copy
   // succeeds.
   virtual bool CopyFile(const Pathname &old_path, const Pathname &new_path) = 0;
 
   // Returns true if pathname refers to a directory
   virtual bool IsFolder(const Pathname& pathname) = 0;
 
   // Returns true if pathname refers to a file
   virtual bool IsFile(const Pathname& pathname) = 0;
 
@@ skipping 184 matching lines @@
     Filesystem::set_default_filesystem(old_fs_);
   }
  private:
   FilesystemInterface* old_fs_;
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FilesystemScope);
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_FILEUTILS_H_