Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2647293006: Fixing cross-compiling issues on android arm (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing cross-compiling issues on android arm BUG=webrtc:7042 Review-Url: https://codereview.webrtc.org/2647293006 Cr-Commit-Position: refs/heads/master@{#16265} Committed: https://chromium.googlesource.com/external/webrtc/+/e5dc3cefabd29cd68e42bb1017e1d899a8965988

Patch Set 1 #

Patch Set 2 : Using rtc_build_with_neon to fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 3 chunks +8 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mbonadei
3 years, 11 months ago (2017-01-24 15:19:47 UTC) #2
mbonadei
On 2017/01/24 15:19:47, mbonadei wrote: It seems that we are now green. I used "rtc_build_with_neon" ...
3 years, 11 months ago (2017-01-25 10:55:08 UTC) #3
kjellander_webrtc
lgtm
3 years, 11 months ago (2017-01-25 11:39:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2647293006/20001
3 years, 11 months ago (2017-01-25 12:29:51 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 13:34:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/e5dc3cefabd29cd68e42bb101...

Powered by Google App Engine
This is Rietveld 408576698