Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: webrtc/modules/audio_processing/BUILD.gn

Issue 2647293006: Fixing cross-compiling issues on android arm (Closed)
Patch Set: Using rtc_build_with_neon to fix deps Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/audio_coding/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/arm.gni") 9 import("//build/config/arm.gni")
10 import("//third_party/protobuf/proto_library.gni") 10 import("//third_party/protobuf/proto_library.gni")
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 "ns/windows_private.h", 277 "ns/windows_private.h",
278 ] 278 ]
279 } 279 }
280 280
281 deps = [ 281 deps = [
282 "../..:webrtc_common", 282 "../..:webrtc_common",
283 "../../base:rtc_base_approved", 283 "../../base:rtc_base_approved",
284 "../../common_audio", 284 "../../common_audio",
285 "../../system_wrappers", 285 "../../system_wrappers",
286 ] 286 ]
287
288 if (rtc_build_with_neon) {
289 deps += [ ":audio_processing_neon_c" ]
290 }
287 } 291 }
288 292
289 if (rtc_enable_protobuf) { 293 if (rtc_enable_protobuf) {
290 proto_library("audioproc_debug_proto") { 294 proto_library("audioproc_debug_proto") {
291 sources = [ 295 sources = [
292 "debug.proto", 296 "debug.proto",
293 ] 297 ]
294 298
295 proto_out_dir = "webrtc/modules/audio_processing" 299 proto_out_dir = "webrtc/modules/audio_processing"
296 } 300 }
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 ] 362 ]
359 363
360 if (apm_debug_dump) { 364 if (apm_debug_dump) {
361 defines = [ "WEBRTC_APM_DEBUG_DUMP=1" ] 365 defines = [ "WEBRTC_APM_DEBUG_DUMP=1" ]
362 } else { 366 } else {
363 defines = [ "WEBRTC_APM_DEBUG_DUMP=0" ] 367 defines = [ "WEBRTC_APM_DEBUG_DUMP=0" ]
364 } 368 }
365 } 369 }
366 370
367 rtc_static_library("audio_processing_neon_c") { 371 rtc_static_library("audio_processing_neon_c") {
372 # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
373 # Errors on cyclic dependency with :audio_processing_c if enabled.
374 check_includes = false
375
368 sources = [ 376 sources = [
369 "ns/nsx_core_neon.c", 377 "ns/nsx_core_neon.c",
370 ] 378 ]
371 379
372 if (current_cpu != "arm64") { 380 if (current_cpu != "arm64") {
373 # Enable compilation for the NEON instruction set. This is needed 381 # Enable compilation for the NEON instruction set. This is needed
374 # since //build/config/arm.gni only enables NEON for iOS, not Android. 382 # since //build/config/arm.gni only enables NEON for iOS, not Android.
375 # This provides the same functionality as webrtc/build/arm_neon.gypi. 383 # This provides the same functionality as webrtc/build/arm_neon.gypi.
376 suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ] 384 suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
377 cflags = [ "-mfpu=neon" ] 385 cflags = [ "-mfpu=neon" ]
378 } 386 }
379 387
380 # Disable LTO on NEON targets due to compiler bug. 388 # Disable LTO on NEON targets due to compiler bug.
381 # TODO(fdegans): Enable this. See crbug.com/408997. 389 # TODO(fdegans): Enable this. See crbug.com/408997.
382 if (rtc_use_lto) { 390 if (rtc_use_lto) {
383 cflags -= [ 391 cflags -= [
384 "-flto", 392 "-flto",
385 "-ffat-lto-objects", 393 "-ffat-lto-objects",
386 ] 394 ]
387 } 395 }
388 deps = [ 396 deps = [
389 ":audio_processing_c",
390 "../../base:rtc_base_approved", 397 "../../base:rtc_base_approved",
391 ] 398 ]
392 } 399 }
393 } 400 }
394 401
395 if (rtc_include_tests) { 402 if (rtc_include_tests) {
396 group("audio_processing_tests") { 403 group("audio_processing_tests") {
397 testonly = true 404 testonly = true
398 public_deps = [ 405 public_deps = [
399 ":audioproc_test_utils", 406 ":audioproc_test_utils",
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 ] 725 ]
719 726
720 deps = [ 727 deps = [
721 ":audioproc_debug_proto", 728 ":audioproc_debug_proto",
722 "../..:webrtc_common", 729 "../..:webrtc_common",
723 "../../base:rtc_base_approved", 730 "../../base:rtc_base_approved",
724 ] 731 ]
725 } 732 }
726 } 733 }
727 } 734 }
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698