Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: webrtc/modules/audio_coding/BUILD.gn

Issue 2647293006: Fixing cross-compiling issues on android arm (Closed)
Patch Set: Using rtc_build_with_neon to fix deps Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_processing/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../build/webrtc.gni") 9 import("../../build/webrtc.gni")
10 import("audio_coding.gni") 10 import("audio_coding.gni")
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 deps = [ 701 deps = [
702 ":audio_decoder_interface", 702 ":audio_decoder_interface",
703 ":audio_encoder_interface", 703 ":audio_encoder_interface",
704 ":isac_common", 704 ":isac_common",
705 "../..:webrtc_common", 705 "../..:webrtc_common",
706 "../../base:rtc_base_approved", 706 "../../base:rtc_base_approved",
707 "../../common_audio", 707 "../../common_audio",
708 "../../system_wrappers", 708 "../../system_wrappers",
709 ] 709 ]
710 710
711 if (rtc_build_with_neon) {
712 deps += [ ":isac_neon" ]
713 }
714
711 if (current_cpu == "arm" && arm_version >= 7) { 715 if (current_cpu == "arm" && arm_version >= 7) {
712 sources += [ 716 sources += [
713 "codecs/isac/fix/source/lattice_armv7.S", 717 "codecs/isac/fix/source/lattice_armv7.S",
714 "codecs/isac/fix/source/pitch_filter_armv6.S", 718 "codecs/isac/fix/source/pitch_filter_armv6.S",
715 ] 719 ]
716 sources -= [ 720 sources -= [
717 "codecs/isac/fix/source/lattice_c.c", 721 "codecs/isac/fix/source/lattice_c.c",
718 "codecs/isac/fix/source/pitch_filter_c.c", 722 "codecs/isac/fix/source/pitch_filter_c.c",
719 ] 723 ]
720 } 724 }
(...skipping 18 matching lines...) Expand all
739 "codecs/isac/fix/source/lpc_masking_model_mips.c", 743 "codecs/isac/fix/source/lpc_masking_model_mips.c",
740 "codecs/isac/fix/source/pitch_filter_mips.c", 744 "codecs/isac/fix/source/pitch_filter_mips.c",
741 ] 745 ]
742 sources -= [ "codecs/isac/fix/source/pitch_filter_c.c" ] 746 sources -= [ "codecs/isac/fix/source/pitch_filter_c.c" ]
743 } 747 }
744 } 748 }
745 } 749 }
746 750
747 if (rtc_build_with_neon) { 751 if (rtc_build_with_neon) {
748 rtc_static_library("isac_neon") { 752 rtc_static_library("isac_neon") {
753 # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
754 # Errors on cyclic dependency with :isac_fix_c if enabled.
755 check_includes = false
756
749 sources = [ 757 sources = [
750 "codecs/isac/fix/source/entropy_coding_neon.c", 758 "codecs/isac/fix/source/entropy_coding_neon.c",
751 "codecs/isac/fix/source/filterbanks_neon.c", 759 "codecs/isac/fix/source/filterbanks_neon.c",
752 "codecs/isac/fix/source/filters_neon.c", 760 "codecs/isac/fix/source/filters_neon.c",
753 "codecs/isac/fix/source/lattice_neon.c", 761 "codecs/isac/fix/source/lattice_neon.c",
754 "codecs/isac/fix/source/transform_neon.c", 762 "codecs/isac/fix/source/transform_neon.c",
755 ] 763 ]
756 764
757 if (current_cpu != "arm64") { 765 if (current_cpu != "arm64") {
758 # Enable compilation for the NEON instruction set. This is needed 766 # Enable compilation for the NEON instruction set. This is needed
759 # since //build/config/arm.gni only enables NEON for iOS, not Android. 767 # since //build/config/arm.gni only enables NEON for iOS, not Android.
760 # This provides the same functionality as webrtc/build/arm_neon.gypi. 768 # This provides the same functionality as webrtc/build/arm_neon.gypi.
761 suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ] 769 suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
762 cflags = [ "-mfpu=neon" ] 770 cflags = [ "-mfpu=neon" ]
763 } 771 }
764 772
765 # Disable LTO on NEON targets due to compiler bug. 773 # Disable LTO on NEON targets due to compiler bug.
766 # TODO(fdegans): Enable this. See crbug.com/408997. 774 # TODO(fdegans): Enable this. See crbug.com/408997.
767 if (rtc_use_lto) { 775 if (rtc_use_lto) {
768 cflags -= [ 776 cflags -= [
769 "-flto", 777 "-flto",
770 "-ffat-lto-objects", 778 "-ffat-lto-objects",
771 ] 779 ]
772 } 780 }
773 781
774 deps = [ 782 deps = [
775 ":isac_fix_c",
776 "../../base:rtc_base_approved", 783 "../../base:rtc_base_approved",
777 "../../common_audio", 784 "../../common_audio",
778 ] 785 ]
779 } 786 }
780 } 787 }
781 788
782 config("pcm16b_config") { 789 config("pcm16b_config") {
783 include_dirs = [ 790 include_dirs = [
784 "../../..", 791 "../../..",
785 "codecs/pcm16b/include", 792 "codecs/pcm16b/include",
(...skipping 1270 matching lines...) Expand 10 before | Expand all | Expand 10 after
2056 ":neteq_unittest_proto", 2063 ":neteq_unittest_proto",
2057 ] 2064 ]
2058 } 2065 }
2059 2066
2060 if (!build_with_chromium && is_clang) { 2067 if (!build_with_chromium && is_clang) {
2061 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 2068 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
2062 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 2069 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
2063 } 2070 }
2064 } 2071 }
2065 } 2072 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_processing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698