Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2625903005: Reland of Android: Add field trial for Intel HW Vp8 encoder (Closed)

Created:
3 years, 11 months ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android: Add field trial for Intel HW Vp8 encoder (patchset #1 id:1 of https://codereview.webrtc.org/2624143002/ ) Reason for revert: Fixed external test issues. Original issue's description: > Revert of Android: Add field trial for Intel HW Vp8 encoder (patchset #1 id:1 of https://codereview.webrtc.org/2614373004/ ) > > Reason for revert: > Breaks external test code. > > Original issue's description: > > Android: Add field trial for Intel HW Vp8 encoder > > > > Also enable Intel HW Vp8 encoder by default in AppRTCMobile. > > > > BUG=webrtc:6683 > > > > Review-Url: https://codereview.webrtc.org/2614373004 > > Cr-Commit-Position: refs/heads/master@{#16002} > > Committed: https://chromium.googlesource.com/external/webrtc/+/cecf86e9b0ba41c35eda360ae24b17b333ae1977 > > TBR=sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6683 > > Review-Url: https://codereview.webrtc.org/2624143002 > Cr-Commit-Position: refs/heads/master@{#16005} > Committed: https://chromium.googlesource.com/external/webrtc/+/c999a08128360b945ce94f6990afa9b6a77cea5e TBR=sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6683 Review-Url: https://codereview.webrtc.org/2625903005 Cr-Commit-Position: refs/heads/master@{#16025} Committed: https://chromium.googlesource.com/external/webrtc/+/295760daa187d30aa81f6cc5f7768538080c09f6

Patch Set 1 #

Patch Set 2 : Ignore field trials when jingle_peerconnection_so is not available #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 1 5 chunks +16 lines, -7 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java View 1 2 chunks +12 lines, -2 lines 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
magjed_webrtc
Created Reland of Android: Add field trial for Intel HW Vp8 encoder
3 years, 11 months ago (2017-01-11 14:03:14 UTC) #1
magjed_webrtc
Sami - please take a look.
3 years, 11 months ago (2017-01-11 16:02:57 UTC) #2
sakal
lgtm
3 years, 11 months ago (2017-01-12 08:14:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2625903005/70001
3 years, 11 months ago (2017-01-12 09:11:53 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 09:12:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/external/webrtc/+/295760daa187d30aa81f6cc5f...

Powered by Google App Engine
This is Rietveld 408576698