Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2614373004: Android: Add field trial for Intel HW Vp8 encoder (Closed)

Created:
3 years, 11 months ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Add field trial for Intel HW Vp8 encoder Also enable Intel HW Vp8 encoder by default in AppRTCMobile. BUG=webrtc:6683 Review-Url: https://codereview.webrtc.org/2614373004 Cr-Commit-Position: refs/heads/master@{#16002} Committed: https://chromium.googlesource.com/external/webrtc/+/cecf86e9b0ba41c35eda360ae24b17b333ae1977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 5 chunks +16 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
magjed_webrtc
Sami - please take a look.
3 years, 11 months ago (2017-01-10 13:07:02 UTC) #5
sakal
lgtm I haven't used field trials though so I don't know if this enough to ...
3 years, 11 months ago (2017-01-10 14:16:42 UTC) #8
magjed_webrtc
On 2017/01/10 14:16:42, sakal wrote: > lgtm > > I haven't used field trials though ...
3 years, 11 months ago (2017-01-10 14:20:50 UTC) #9
sakal
On 2017/01/10 14:20:50, magjed_webrtc wrote: > On 2017/01/10 14:16:42, sakal wrote: > > lgtm > ...
3 years, 11 months ago (2017-01-10 14:32:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2614373004/1
3 years, 11 months ago (2017-01-11 08:55:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cecf86e9b0ba41c35eda360ae24b17b333ae1977
3 years, 11 months ago (2017-01-11 08:57:47 UTC) #15
magjed_webrtc
3 years, 11 months ago (2017-01-11 11:01:26 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2624143002/ by magjed@webrtc.org.

The reason for reverting is: Breaks external test code..

Powered by Google App Engine
This is Rietveld 408576698