Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2621003002: Android: Wrap webrtc::field_trial::FindFullName in Java (Closed)

Created:
3 years, 11 months ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Wrap webrtc::field_trial::FindFullName in Java The purpose is to be able to add field trials in Java code. BUG=webrtc:6683 Review-Url: https://codereview.webrtc.org/2621003002 Cr-Commit-Position: refs/heads/master@{#15994} Committed: https://chromium.googlesource.com/external/webrtc/+/c0ce6cc85e0929277dc378eefa5ec766da9e36c3

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
magjed_webrtc
Sami - please take a look.
3 years, 11 months ago (2017-01-10 13:03:09 UTC) #5
sakal
lgtm
3 years, 11 months ago (2017-01-10 14:23:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2621003002/20001
3 years, 11 months ago (2017-01-10 14:40:03 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 16:02:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c0ce6cc85e0929277dc378eef...

Powered by Google App Engine
This is Rietveld 408576698