Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2624143002: Revert of Android: Add field trial for Intel HW Vp8 encoder (Closed)

Created:
3 years, 11 months ago by magjed_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android: Add field trial for Intel HW Vp8 encoder (patchset #1 id:1 of https://codereview.webrtc.org/2614373004/ ) Reason for revert: Breaks external test code. Original issue's description: > Android: Add field trial for Intel HW Vp8 encoder > > Also enable Intel HW Vp8 encoder by default in AppRTCMobile. > > BUG=webrtc:6683 > > Review-Url: https://codereview.webrtc.org/2614373004 > Cr-Commit-Position: refs/heads/master@{#16002} > Committed: https://chromium.googlesource.com/external/webrtc/+/cecf86e9b0ba41c35eda360ae24b17b333ae1977 TBR=sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6683 Review-Url: https://codereview.webrtc.org/2624143002 Cr-Commit-Position: refs/heads/master@{#16005} Committed: https://chromium.googlesource.com/external/webrtc/+/c999a08128360b945ce94f6990afa9b6a77cea5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 5 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
magjed_webrtc
Created Revert of Android: Add field trial for Intel HW Vp8 encoder
3 years, 11 months ago (2017-01-11 11:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2624143002/1
3 years, 11 months ago (2017-01-11 11:01:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c999a08128360b945ce94f6990afa9b6a77cea5e
3 years, 11 months ago (2017-01-11 11:02:16 UTC) #6
magjed_webrtc
3 years, 11 months ago (2017-01-11 14:03:13 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2625903005/ by magjed@webrtc.org.

The reason for reverting is: Fixed external test issues..

Powered by Google App Engine
This is Rietveld 408576698