Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2623513006: RTCMediaStreamTrackStats.kind added and collected. (Closed)

Created:
3 years, 11 months ago by hbos
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCMediaStreamTrackStats.kind added and collected. Implements recent spec change: https://github.com/w3c/webrtc-stats/pull/127 BUG=chromium:659137, chromium:627816 Review-Url: https://codereview.webrtc.org/2623513006 Cr-Commit-Position: refs/heads/master@{#16111} Committed: https://chromium.googlesource.com/external/webrtc/+/160e4a78e30041258a86e115bddaf5074f36d2b6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase with master #

Patch Set 3 : Rebase with master #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 2 1 chunk +13 lines, -5 lines 1 comment Download
M webrtc/api/rtcstatscollector.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 2 5 chunks +10 lines, -5 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 2 5 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 30 (19 generated)
hbos
Please take a look, hta.
3 years, 11 months ago (2017-01-10 15:45:56 UTC) #4
hbos
https://codereview.webrtc.org/2623513006/diff/1/webrtc/api/stats/rtcstats_objects.h File webrtc/api/stats/rtcstats_objects.h (right): https://codereview.webrtc.org/2623513006/diff/1/webrtc/api/stats/rtcstats_objects.h#newcode47 webrtc/api/stats/rtcstats_objects.h:47: // https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-kind URL from rawgit converted to github.io, but ...
3 years, 11 months ago (2017-01-10 15:47:14 UTC) #5
hta-webrtc
lgtm https://codereview.webrtc.org/2623513006/diff/1/webrtc/api/stats/rtcstats_objects.h File webrtc/api/stats/rtcstats_objects.h (right): https://codereview.webrtc.org/2623513006/diff/1/webrtc/api/stats/rtcstats_objects.h#newcode47 webrtc/api/stats/rtcstats_objects.h:47: // https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-kind On 2017/01/10 15:47:14, hbos wrote: > ...
3 years, 11 months ago (2017-01-11 12:36:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2623513006/1
3 years, 11 months ago (2017-01-11 12:44:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2623513006/20001
3 years, 11 months ago (2017-01-16 13:05:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/15225)
3 years, 11 months ago (2017-01-16 14:47:54 UTC) #19
hbos
https://codereview.webrtc.org/2623513006/diff/40001/webrtc/api/rtcstats_integrationtest.cc File webrtc/api/rtcstats_integrationtest.cc (right): https://codereview.webrtc.org/2623513006/diff/40001/webrtc/api/rtcstats_integrationtest.cc#newcode443 webrtc/api/rtcstats_integrationtest.cc:443: // Is this a real problem or an artifact ...
3 years, 11 months ago (2017-01-16 22:15:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2623513006/40001
3 years, 11 months ago (2017-01-16 22:15:49 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/18835)
3 years, 11 months ago (2017-01-16 22:58:27 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2623513006/40001
3 years, 11 months ago (2017-01-17 08:46:44 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 10:53:27 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/160e4a78e30041258a86e115b...

Powered by Google App Engine
This is Rietveld 408576698