Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2623513006: RTCMediaStreamTrackStats.kind added and collected. (Closed)
Patch Set: Rebase with master Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index 1f96bcd9dc88e6d151b161094b048b48b5252d92..e8a1842dbe8e3e82a2125d78bf70cb454d8e56df 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -51,6 +51,14 @@ struct RTCDtlsTransportState {
static const char* kFailed;
};
+// |RTCMediaStreamTrackStats::kind| is not an enum in the spec but the only
+// valid values are "audio" and "video".
+// https://w3c.github.io/webrtc-stats/#dom-rtcmediastreamtrackstats-kind
+struct RTCMediaStreamTrackKind {
+ static const char* kAudio;
+ static const char* kVideo;
+};
+
// https://w3c.github.io/webrtc-stats/#certificatestats-dict*
class RTCCertificateStats final : public RTCStats {
public:
@@ -237,8 +245,10 @@ class RTCMediaStreamTrackStats final : public RTCStats {
public:
WEBRTC_RTCSTATS_DECL();
- RTCMediaStreamTrackStats(const std::string& id, int64_t timestamp_us);
- RTCMediaStreamTrackStats(std::string&& id, int64_t timestamp_us);
+ RTCMediaStreamTrackStats(const std::string& id, int64_t timestamp_us,
+ const char* kind);
+ RTCMediaStreamTrackStats(std::string&& id, int64_t timestamp_us,
+ const char* kind);
RTCMediaStreamTrackStats(const RTCMediaStreamTrackStats& other);
~RTCMediaStreamTrackStats() override;
@@ -248,6 +258,8 @@ class RTCMediaStreamTrackStats final : public RTCStats {
// TODO(hbos): |RTCStatsCollector| does not return stats for detached tracks.
// crbug.com/659137
RTCStatsMember<bool> detached;
+ // See |RTCMediaStreamTrackKind| for valid values.
+ RTCStatsMember<std::string> kind;
// Video-only members
RTCStatsMember<uint32_t> frame_width;
RTCStatsMember<uint32_t> frame_height;

Powered by Google App Engine
This is Rietveld 408576698