Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: webrtc/stats/rtcstats_objects.cc

Issue 2623513006: RTCMediaStreamTrackStats.kind added and collected. (Closed)
Patch Set: Rebase with master Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/stats/rtcstats_objects.cc
diff --git a/webrtc/stats/rtcstats_objects.cc b/webrtc/stats/rtcstats_objects.cc
index 1b9d12a75b54fd40f54c580a3e551eb6fe2ef111..af87e717405c12f945de1c0afb4cc014b6c1ae4f 100644
--- a/webrtc/stats/rtcstats_objects.cc
+++ b/webrtc/stats/rtcstats_objects.cc
@@ -35,6 +35,9 @@ const char* RTCDtlsTransportState::kConnected = "connected";
const char* RTCDtlsTransportState::kClosed = "closed";
const char* RTCDtlsTransportState::kFailed = "failed";
+const char* RTCMediaStreamTrackKind::kAudio = "audio";
+const char* RTCMediaStreamTrackKind::kVideo = "video";
+
WEBRTC_RTCSTATS_IMPL(RTCCertificateStats, RTCStats, "certificate",
&fingerprint,
&fingerprint_algorithm,
@@ -350,6 +353,7 @@ WEBRTC_RTCSTATS_IMPL(RTCMediaStreamTrackStats, RTCStats, "track",
&remote_source,
&ended,
&detached,
+ &kind,
&frame_width,
&frame_height,
&frames_per_second,
@@ -365,17 +369,18 @@ WEBRTC_RTCSTATS_IMPL(RTCMediaStreamTrackStats, RTCStats, "track",
&echo_return_loss_enhancement);
RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(
- const std::string& id, int64_t timestamp_us)
- : RTCMediaStreamTrackStats(std::string(id), timestamp_us) {
+ const std::string& id, int64_t timestamp_us, const char* kind)
+ : RTCMediaStreamTrackStats(std::string(id), timestamp_us, kind) {
}
RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(
- std::string&& id, int64_t timestamp_us)
+ std::string&& id, int64_t timestamp_us, const char* kind)
: RTCStats(std::move(id), timestamp_us),
track_identifier("trackIdentifier"),
remote_source("remoteSource"),
ended("ended"),
detached("detached"),
+ kind("kind", kind),
frame_width("frameWidth"),
frame_height("frameHeight"),
frames_per_second("framesPerSecond"),
@@ -389,6 +394,8 @@ RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(
audio_level("audioLevel"),
echo_return_loss("echoReturnLoss"),
echo_return_loss_enhancement("echoReturnLossEnhancement") {
+ RTC_DCHECK(kind == RTCMediaStreamTrackKind::kAudio ||
+ kind == RTCMediaStreamTrackKind::kVideo);
}
RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(
@@ -398,6 +405,7 @@ RTCMediaStreamTrackStats::RTCMediaStreamTrackStats(
remote_source(other.remote_source),
ended(other.ended),
detached(other.detached),
+ kind(other.kind),
frame_width(other.frame_width),
frame_height(other.frame_height),
frames_per_second(other.frames_per_second),
« webrtc/api/rtcstats_integrationtest.cc ('K') | « webrtc/api/stats/rtcstats_objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698