Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2622553003: Provide better message for when RTCP mux "require" policy is triggered. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Provide better message for when RTCP mux "require" policy is triggered. Previously: Failed to setup RTCP mux filter. Now: rtcpMuxPolicy is 'require', but media description does not contain 'a=rtcp-mux'. BUG=webrtc:6966 Review-Url: https://codereview.webrtc.org/2622553003 Cr-Commit-Position: refs/heads/master@{#16062} Committed: https://chromium.googlesource.com/external/webrtc/+/8e814d79063c30435ef3bfa0da40661ba0846c94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/pc/channel.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
pthatcher1
lgtm
3 years, 11 months ago (2017-01-11 21:30:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2622553003/1
3 years, 11 months ago (2017-01-13 18:34:29 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 19:34:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8e814d79063c30435ef3bfa0d...

Powered by Google App Engine
This is Rietveld 408576698