Refactoring of RTCP options in BaseChannel.

Refactoring of RTCP options in BaseChannel.

Previously, BaseChannel supported a "no RTCP" mode, which wasn't
being used any more and is being deleted.

Also, "RTCP mux required" previously worked by calling "ActivateRtcpMux"
after construction. Now it works by explicitly passing a
"require_rtcp_mux" parameter into the constructor.

BUG=None

Review-Url: https://codereview.webrtc.org/2622613004
Cr-Commit-Position: refs/heads/master@{#16045}
Committed: https://chromium.googlesource.com/external/webrtc/+/ac22f70906175831270b399e20d0519198ac6922

[pthatcher1, 2017-01-12 23:17:57]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2017-01-12 23:17:58]

lgtm

[Taylor Brandstetter, 2017-01-13 05:07:02]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-13 05:07:02]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2622613004/#ps60001 (title:
"Minor renaming/adding a comment, which makes sense to do after this
refactoring.")

[commit-bot: I haz the power, 2017-01-13 05:07:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-13 05:59:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484284022198940,
"parent_rev": "9d95666fea252a704ac9535e7cdca5a3619c3e3c", "commit_rev":
"ac22f70906175831270b399e20d0519198ac6922"}

[commit-bot: I haz the power, 2017-01-13 05:59:32]

Description was changed from

==========
Refactoring of RTCP options in BaseChannel.

Previously, BaseChannel supported a "no RTCP" mode, which wasn't
being used any more and is being deleted.

Also, "RTCP mux required" previously worked by calling "ActivateRtcpMux"
after construction. Now it works by explicitly passing a
"require_rtcp_mux" parameter into the constructor.

BUG=None
==========

to

==========
Refactoring of RTCP options in BaseChannel.

Previously, BaseChannel supported a "no RTCP" mode, which wasn't
being used any more and is being deleted.

Also, "RTCP mux required" previously worked by calling "ActivateRtcpMux"
after construction. Now it works by explicitly passing a
"require_rtcp_mux" parameter into the constructor.

BUG=None

Review-Url: https://codereview.webrtc.org/2622613004
Cr-Commit-Position: refs/heads/master@{#16045}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ac22f70906175831270b399e2...
==========

[commit-bot: I haz the power, 2017-01-13 05:59:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/ac22f70906175831270b399e2...

[keishi, 2017-01-13 06:29:48]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2626023005/ by keishi@chromium.org.

The reason for reverting is: Broke Mac64 Release [large tests] build
https://build.chromium.org/p/client.webrtc/builders/Mac64%20Release%20%5Blarg....