Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: webrtc/pc/channel.cc

Issue 2622553003: Provide better message for when RTCP mux "require" policy is triggered. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel.cc
diff --git a/webrtc/pc/channel.cc b/webrtc/pc/channel.cc
index f242f17bd23b0efdef5ac76a7ba7f1dce6dbab82..df26d4cdb818483980fffff344e85015d716f454 100644
--- a/webrtc/pc/channel.cc
+++ b/webrtc/pc/channel.cc
@@ -1183,6 +1183,15 @@ bool BaseChannel::SetRtcpMux_n(bool enable,
ContentAction action,
ContentSource src,
std::string* error_desc) {
+ // Provide a more specific error message for the RTCP mux "require" policy
+ // case.
+ if (rtcp_mux_required_ && !enable) {
+ SafeSetError(
+ "rtcpMuxPolicy is 'require', but media description does not "
+ "contain 'a=rtcp-mux'.",
+ error_desc);
+ return false;
+ }
bool ret = false;
switch (action) {
case CA_OFFER:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698