Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2615873002: Reland of actor webrtc_perf_tests into several source_sets. (Closed)

Created:
3 years, 11 months ago by ehmaldonado_webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, hlundin-webrtc, yujie_mao (webrtc), kwiberg-webrtc, zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, aluebs-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of actor webrtc_perf_tests into several source_sets. (patchset #1 id:1 of https://codereview.webrtc.org/2613913002/ ) Reason for revert: Try again. Original issue's description: > Revert of Refactor webrtc_perf_tests into several source_sets. (patchset #5 id:100001 of https://codereview.webrtc.org/2609403002/ ) > > Reason for revert: > Probably cause unexpected performance regression > BUG=chromium:678569 > > Original issue's description: > > Refactor webrtc_perf_tests into several source_sets. > > > > BUG=webrtc:6954 > > > > Review-Url: https://codereview.webrtc.org/2609403002 > > Cr-Commit-Position: refs/heads/master@{#15902} > > Committed: https://chromium.googlesource.com/external/webrtc/+/0b5a26a5768618e5d850aa7ea97cb348fe5302f7 > > TBR=kjellander@webrtc.org,ehmaldonado@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6954 > > Review-Url: https://codereview.webrtc.org/2613913002 > Cr-Commit-Position: refs/heads/master@{#15916} > Committed: https://chromium.googlesource.com/external/webrtc/+/5fbcd228f0781526ce2cbafba0a1f39f481ad81b TBR=kjellander@webrtc.org,danilchap@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:678569 Review-Url: https://codereview.webrtc.org/2615873002 Cr-Commit-Position: refs/heads/master@{#15919} Committed: https://chromium.googlesource.com/external/webrtc/+/021eef32f408558bbd11c5ac6eeaa1b15386762c

Patch Set 1 : Pristine copy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -36 lines) Patch
M webrtc/BUILD.gn View 2 chunks +6 lines, -36 lines 0 comments Download
M webrtc/call/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ehmaldonado_webrtc
Created Reland of actor webrtc_perf_tests into several source_sets.
3 years, 11 months ago (2017-01-05 13:11:18 UTC) #1
ehmaldonado_webrtc
On 2017/01/05 13:11:18, ehmaldonado_webrtc wrote: > Created Reland of actor webrtc_perf_tests into several source_sets. Sorry ...
3 years, 11 months ago (2017-01-05 13:15:11 UTC) #2
danilchap
On 2017/01/05 13:15:11, ehmaldonado_webrtc wrote: > On 2017/01/05 13:11:18, ehmaldonado_webrtc wrote: > > Created Reland ...
3 years, 11 months ago (2017-01-05 13:17:42 UTC) #3
ehmaldonado_webrtc
On 2017/01/05 13:17:42, danilchap wrote: > On 2017/01/05 13:15:11, ehmaldonado_webrtc wrote: > > On 2017/01/05 ...
3 years, 11 months ago (2017-01-05 13:20:12 UTC) #4
danilchap
Perfomance regression seem unaffected by the revert. lgtm
3 years, 11 months ago (2017-01-05 14:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2615873002/1
3 years, 11 months ago (2017-01-05 15:09:45 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 15:09:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/021eef32f408558bbd11c5ac6...

Powered by Google App Engine
This is Rietveld 408576698